Red Hat Bugzilla – Bug 867100
Backport upstream commit f26d2e5f99ff402910407165ae228025991151b9 to fix unittests
Last modified: 2013-03-22 21:01:31 EDT
Description of problem:
Unit tests failing on F17 and later with the following problem:
Traceback (most recent call last):
File "/home/pportant/Documents/RHS/OpenStack/Swift/tree/test/unit/common/middleware/test_swift3.py", line 478, in test_object_GET_Range
resp = local_app(req.environ, local_app.app.do_start_response)
File "/home/pportant/Documents/RHS/OpenStack/Swift/tree/swift/common/middleware/swift3.py", line 479, in __call__
res = getattr(controller, req.method)(env, start_response)
File "/home/pportant/Documents/RHS/OpenStack/Swift/tree/swift/common/middleware/swift3.py", line 378, in GET
return self.GETorHEAD(env, start_response)
File "/home/pportant/Documents/RHS/OpenStack/Swift/tree/swift/common/middleware/swift3.py", line 339, in GETorHEAD
app_iter = self.app(env, self.do_start_response)
File "/home/pportant/Documents/RHS/OpenStack/Swift/tree/test/unit/common/middleware/test_swift3.py", line 151, in __call__
AttributeError: 'AppIterRange' object has no attribute 'pop'
Version-Release number of selected component (if applicable):
F17 and later
Steps to Reproduce:
1. checkout openstack swift
2. run unit tests (./.unitests)
3. observe problem of one failed test, which prevents others from running
Unit tests fail to run in the test_swift3 tests for F17
All unit tests run and pass.
Upstream commit link is:
You can find a version of this fix already backported against 1.4.8 at:
if this helps.
Any reason not to move to Swift 1.7.4 in F18 ?
swift3 (S3 emulation) was removed in Swift 1.5.0 so backporting related unit test fixes doesn't feel like a high priority.
 moved to a stand-alone project https://github.com/fujita/swift3
I had thought that F18 was already 1.7.4, if it isn't then I agree we should move F18 to 1.7.4.
For F17 though, I think it is worth while to make sure the unit tests still run so that as other patches are applied, this whole suite of tests is not missed.
While I agree it is not a high priority, it still seems worth the effort, and since the patch is trivial, we apparently gain a lot (successful unit tests runs) by taking it.
Fixed in openstack-swift-plugin-swift3-1.7-2.fc20, closing.
BTW, we now have other unit test failures in swift3 on Rawhide.
Need upstream work and possibly a separate bug.