Red Hat Bugzilla – Bug 868311
RFE - Floppyinject hook does not work under 3.1
Last modified: 2012-11-14 15:17:52 EST
Description of problem:
After conversation with Shahar, it seems like the floppyinject VDSM hook we used in CloudForms 1.0 to deliver user-data into instance does not longer work under RHEV-M 3.1. According to Shahar, the internal API changed:
there is code changes the first that I see is the utils.execCmd() now you
need to change it to hooking.execCmd() (parameters are the same)
and you need to remove the 'import utils' and it suppose to work.
It is possible to have this fixed in a way that it will not break the backward compatibility? (I mean it will continue to work on <3.0 but also work on 3.1).
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Install vdsm-hook-floppyinject
2. Specify the custom_properties when creating a new VM
3. Hook does not work.
Moving to vdsm-hook-floppyinject component on cloudforms
(In reply to comment #1)
> Moving to vdsm-hook-floppyinject component on cloudforms
My understanding was that the root cause of the breakage is that the internal api changed between 3.0 and 3.1. See the citation in the original description.
Perhaps we're saying that that internal api was never documented, and we shouldn't have expected it to stay stable? In that case, I concur; this belongs to the floppyinject hook.
(In reply to comment #3)
> (In reply to comment #1)
> > Moving to vdsm-hook-floppyinject component on cloudforms
> My understanding was that the root cause of the breakage is that the
> internal api changed between 3.0 and 3.1. See the citation in the original
> Perhaps we're saying that that internal api was never documented, and we
> shouldn't have expected it to stay stable? In that case, I concur; this
> belongs to the floppyinject hook.
The 3.1 syntax works with 3.0 - I'd recommend moving to that now.
Ah, ok, that makes sense. We weren't using it quite right.
mfojtik joev does this info impact your assessment of what should be done to get this support sorted out in CF 1.1?
I prepared a patch to fix this issue:
I tested this on RHEVM 3.1 (si21) and it works perfectly. Can somebody do a testing for 3.0?
(In reply to comment #10)
> I prepared a patch to fix this issue:
> I tested this on RHEVM 3.1 (si21) and it works perfectly. Can somebody do a
> testing for 3.0?
Shahar can you please check my changes? Just to be sure I did not blow up something :-)
I'd make sure the hook requires the version of vdsm which added the support for this in 3.0.z per bug 835606 (vdsm-4.9-113.2)
(In reply to comment #12)
> I'd make sure the hook requires the version of vdsm which added the support
> for this in 3.0.z per bug 835606 (vdsm-4.9-113.2)
I thought that this change will be backward compatible and from what I understand from Andrew comment, we were using it wrong.
Btw. the patch was merged to:
Re C13: I found the errata, so taking this comment back ;-)
I have tested Michal's patch on RHEVM 3.1 and it worked perfectly.
A patch to DeltaCloud 0.5.0 provides the needed functionality
without the need to use the floppy inject hook.
I believe since there is now a better way to inject user data on RHEVm3.1,
the floppy hook is not required for RHEVm3.1 therefor fixing this
bug is not necessary.
I believe this bug should be close.
Joe is right, this bug fix the bug in vdsm hook however this is not longer a preferred way how to inject data to VM for RHEVM 3.1. Closing this bug as NOTFIX seems appropriate for me.
Also if someone in future will be interested in using this method, the is pushed in GIT repo.