Bug 878320 - Fix for 501871 breaks lib/support
Summary: Fix for 501871 breaks lib/support
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: gallery2
Version: 17
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-20 05:43 UTC by Joel
Modified: 2012-12-06 07:07 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-02 04:29:34 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Joel 2012-11-20 05:43:36 UTC
Description of problem:
going to lib/support/  should bring up the management display but instead does nothing and this error appears in the log:
[Mon Nov 19 21:18:19 2012] [error] [client 71.198.162.152] PHP Fatal error:  Class 'GalleryCoreApi' not found in /usr/share/gallery2/modules/core/classes/GallerySession.class on line 29

Going to line 29, we find the fix for the old Bz 501871 fix:
https://bugzilla.redhat.com/show_bug.cgi?id=501871

 GalleryCoreApi::requireOnce('modules/core/classes/GalleryTranslator.class');  

Commenting that out restores lib/support to work.  Haven't checked yet if that re-breaks capcha with comments.

Joel

Comment 1 Gwyn Ciesla 2012-11-20 13:28:43 UTC
Please let me know once you can test that.

Comment 2 Joel 2012-11-22 21:24:05 UTC
Jon,

I can't test it right now as with recent switch from F14 to F17, captcha no longer displays an image.  Once I troubleshoot that, I can check but that could be an arbitrary time from now.  By the way, that upgrade was a total PITA for my gallery2 install.  mysql changed default from MyISAM to InnoDB and somehow in the conversion, a whole bunch of entries in g2_Item and g2_Entity databases got wiped, breaking connectivity throughout my gallery.  Fortunately, I was able to brush up my mysql-fu and fix all that.

I was able to make the lib/support work by changing line 29 to not use the GalleryCoreApi requireOnce method but to install call the intrinsic require_once:

require_once(dirname(__FILE__) . '/' . 'GalleryTranslator.class');

This should leave capcha functionality identical to before (whether it worked or not), but not require the presence of GalleryCoreApi for the lib/support call path.

Joel

Comment 3 Joel 2012-11-26 00:17:48 UTC
Jon,

I tracked down the issue with captcha and will file a separate bug.  The above seems to work just fine.  Doesn't seem to interfere with Bz 501871 fix.

new captcha bug:
https://bugzilla.redhat.com/show_bug.cgi?id=880006

Joel

Comment 4 Joel 2012-11-26 00:19:00 UTC
by "seems to work just fine"  I mean that the FIX works just fine changing line 29 to use built-in require_once.  Not that there isn't a problem.

Joel

Comment 5 Fedora Update System 2012-11-27 14:20:08 UTC
gallery2-2.3.2-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gallery2-2.3.2-5.fc18

Comment 6 Fedora Update System 2012-11-27 14:20:26 UTC
gallery2-2.3.2-5.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gallery2-2.3.2-5.fc17

Comment 7 Fedora Update System 2012-11-28 02:05:15 UTC
Package gallery2-2.3.2-5.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gallery2-2.3.2-5.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-19138/gallery2-2.3.2-5.fc18
then log in and leave karma (feedback).

Comment 8 Joel 2012-12-01 20:06:49 UTC
Tested update in testing for fc17.  Had no issues.  Seems to work correctly.  Gave karma

Comment 9 Fedora Update System 2012-12-02 04:29:35 UTC
gallery2-2.3.2-5.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2012-12-06 07:07:28 UTC
gallery2-2.3.2-5.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.