Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 878851

Summary: Enhancement: errai-jpa-demo-grocery list - user can submit blank forms
Product: [Retired] JBoss Enterprise WFK Platform 2 Reporter: Stefan Miklosovic <smikloso>
Component: ErraiAssignee: Pavel SLegr <pslegr>
Status: CLOSED CURRENTRELEASE QA Contact: Stefan Miklosovic <smikloso>
Severity: low Docs Contact:
Priority: unspecified    
Version: 2.1.0CC: cbrock, csadilek, jfuerth, mnovotny, oskutka, pslegr
Target Milestone: ER1   
Target Release: 2.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-14 14:54:15 UTC Type: Enhancement
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
item list as it appears after saving empty items none

Description Stefan Miklosovic 2012-11-21 11:57:40 UTC
Created attachment 649177 [details]
item list as it appears after saving empty items

Description of problem:
It is considered to be a bad practice to let a user to create a record in the database in the errai-grocery-list demo while he does not input any strings into the form. Please see the attachment in order to see the issue.

How reproducible:
always

Steps to Reproduce:
1. Click on the "Try The Demo!" button.
2. Click on the "Save" button.
3. The empty record is added among other ones in the "Existing Items" list.
  
Actual results:
User is able to save an empty item.

Expected results:
Opposite of the actual result.

Additional info:
It could be possible to show some infobox popping up upon the attempt of saving an item while there is no information provided at all but actual implementation is highly discutable (it would be nice if it was easilly testable too).

This issue also covers the same proglem at the store page. It seems it is the flaw of the whole application as such.

Comment 1 Jonathan Fuerth 2012-11-21 14:35:23 UTC
Thanks. I'll add Bean Validation as another technology in the demo stack, and add this to the TODO section of README.md.

Comment 2 Marek Novotny 2013-01-10 13:00:15 UTC
Is there a reference to Errai JIRA issue? We need to track it, please file if not exists such issue and link it here. Thanks in advance.

Comment 3 Jonathan Fuerth 2013-01-10 15:41:14 UTC
I think we should close this as invalid. To me, it doesn't make sense to spend productization resources on a work-in-progress. We can revisit this in the Errai 3 release, when the demo is ready for "prime time." :)

Comment 4 Marek Novotny 2013-01-11 10:00:09 UTC
OK, so we remove this demo example from Errai product until it is ready. Do I get it right?

Comment 5 Jonathan Fuerth 2013-01-11 15:56:19 UTC
That's my vote. The to-do list demo covers a lot of the same concepts, but it's less ambitious in scope (and thus, it's finished). We'll get the best return if we focus our efforts there for Errai 2.2 productization.

Comment 6 Pavel SLegr 2013-01-14 11:13:36 UTC
ok, excluded from wfk-2.2

Comment 7 Stefan Miklosovic 2013-02-19 14:17:16 UTC
Verified that jpa-demo-grocery-list is excluded and not present in the jboss-wfk-2.2.0 (and module is commented out in the jpa-examples/pom.xml)

Comment 8 Karel Piwko 2013-05-14 14:54:15 UTC
Closed as CURRENTRELEASE, part of WFK 2.2.0 distributables.