Created attachment 651312 [details] patch to fix mic-e encoding bug Description of problem: aprsd has had a long-standing mic-e packet "clean-up" bug that incorrectly edits a received packet that is gateway to APRS-IS. Version-Release number of selected component (if applicable): 2.2.5-15 How reproducible: Transmit packets with a mic-e protocol device (e.g. Mic Encoder, Kenwood D700, etc.) and notice that valid non-printing characters (e.g. 0x1c) are being blanked. Steps to Reproduce: 1. Transmit mic-e packets 2. Look at data transmitted to APRS-IS servers (see aprs.fi) 3. Notice aprsd-repeated packets don't match those of other correct APRS-IS servers. Actual results: 2012-11-19 17:50:49 UTC: N2MH-8>T0TW5V,WB2ZII*,WIDE2,qAR,WB2ZII-15:'f+%l o1]= Expected results: 2012-11-19 18:00:48 UTC: N2MH-8>T0TW5V,WIDE2-1,qAR,N2MH-12:'f+%l <0x1c>o1]= Additional info: This bug has been in aprsd forever but only manifests in a limited number of cases as the test was for isprint, which excludes the four or so non-printable characters that are allowed by the APRS spec. See ftp://ftp.tapr.org/aprssig/aprsspec/spec/aprs101/APRS101.pdf Chapter 10.
Created attachment 651313 [details] revised SPEC that applies the patch
Created attachment 669945 [details] patch to fix mic-e encoding bug
Created attachment 669946 [details] revised SPEC that applies the patch
Further revised the patch based on feedback from N2MH.
Created attachment 746459 [details] consolidated mic-e and extra trailing blanks patch This patch hopefully fully fixes aprsd to no longer blank out valid mic-e unprintable characters *and* stop tacking on an extra \r on every packet (which are then replaced by blank by the next aprsd in the chain).
Created attachment 746460 [details] updated SPEC
There was an additional bug that was resulting in extra \r's getting tacked on to every packet, which are then getting replaced by a growing string of trailing blanks as each \r was replaced by blank in the next aprsd in the APRS-IS chain. This (hopefully final) patch consolidates my Mic-E and extra-CR fixes into one patch.
This message is a reminder that Fedora 17 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 17. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '17'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 17's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 17 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior to Fedora 17's end of life. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 17 changed to end-of-life (EOL) status on 2013-07-30. Fedora 17 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. Thank you for reporting this bug and we are sorry it could not be fixed.
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23
This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.