Created attachment 651880 [details] spec cleanup for recent packaging guidelines Description of problem: I have attached my suggested changes in patch. Following are the guidelines I used 1) https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define 2) http://fedoraproject.org/wiki/Packaging:Python#BuildRequires Changed BR: python to python2-devel 3) Removed python sitelib %define. See http://fedoraproject.org/wiki/Packaging:Python#Macros 4) Updated scriptlets. The notable change is for gtk2 subpackage as given at http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GTK.2B_modules 5) Can it be possible to fix following issue? Else leave this [!]: SourceX / PatchY prefixed with %{name}. Note: Source1 (xinput-ibus) 6) you can add comment in spec for following issue ibus.x86_64: W: obsolete-not-provided ibus-gnome3 7) can following lines be removed from spec file? # Added for F14: need to keep bumping for backports Obsoletes: ibus-gtk < %{version}-%{release} Provides: ibus-gtk = %{version}-%{release} Another thing is to ask upstream to correct the fsf address in license headers. Version-Release number of selected component (if applicable): ibus-libs-1.4.99.20121109-2.fc18.x86_64.rpm How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
I updated the build. https://brewweb.devel.redhat.com/taskinfo?taskID=5130140 (In reply to comment #0) > Created attachment 651880 [details] > spec cleanup for recent packaging guidelines > > Description of problem: > I have attached my suggested changes in patch. Following are the guidelines > I used OK, looks good. > 2) http://fedoraproject.org/wiki/Packaging:Python#BuildRequires > Changed BR: python to python2-devel I think if python2-devel is used, python2_sitelib is better. -%dir %{python_sitelib}/ibus -%{python_sitelib}/ibus/* +%dir %{python2_sitelib}/ibus +%{python2_sitelib}/ibus/* > 4) Updated scriptlets. The notable change is for gtk2 subpackage as given at > http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GTK.2B_modules This suggests gtk-query-immodules-3.0 only because gtk-query-immodules-2.0 does not have --update-cache option. I also updated the comment line slightly.