Bug 892651 - Review Request: perl-Package-Anon - Anonymous packages
Summary: Review Request: perl-Package-Anon - Anonymous packages
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Robin Lee
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2013-01-07 14:09 UTC by Paul Howarth
Modified: 2013-01-23 01:26 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2013-01-23 01:24:51 UTC
Type: ---
robinlee.sysu: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Paul Howarth 2013-01-07 14:09:42 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Package-Anon/branches/fedora/perl-Package-Anon.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Package-Anon/perl-Package-Anon-0.05-2.fc19.src.rpm

This module allows for anonymous packages that are independent of the main
namespace and only available through an object instance, not by name.

Fedora Account System Username: pghmcfc

Comment 1 Robin Lee 2013-01-12 15:16:56 UTC
Approved by cheeselee.

Package Review

[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 1 files have unknown license. Detailed output of
     licensecheck in /home/cheese/Public/892651-perl-Package-
[x]: Package consistently uses macro is (instead of hard-coded directory
[x]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 30720 bytes in 3 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Package contains the mandatory BuildRequires and Reguires:.
[x]: CPAN urls should be non-versioned.

===== SHOULD items =====

[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[-]: SourceX / PatchY prefixed with %{name}.
     Note: Source0 (Package-Anon-0.05.tar.gz)
[x]: SourceX is a working URL.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
[x]: Large data in /usr/share should live in a noarch subpackage if package is

Checking: perl-Package-Anon-debuginfo-0.05-2.fc19.x86_64.rpm
perl-Package-Anon.x86_64: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace
perl-Package-Anon.src: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages)
# rpmlint perl-Package-Anon perl-Package-Anon-debuginfo
perl-Package-Anon.x86_64: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
# echo 'rpmlint-done:'

perl-Package-Anon-debuginfo-0.05-2.fc19.x86_64.rpm (rpmlib, GLIBC filtered):

perl-Package-Anon-0.05-2.fc19.x86_64.rpm (rpmlib, GLIBC filtered):

    perl-Package-Anon-debuginfo = 0.05-2.fc19
    perl-Package-Anon-debuginfo(x86-64) = 0.05-2.fc19

    perl(Package::Anon) = 0.05
    perl-Package-Anon = 0.05-2.fc19
    perl-Package-Anon(x86-64) = 0.05-2.fc19

Unversioned so-files
perl-Package-Anon-0.05-2.fc19.x86_64.rpm: /usr/lib64/perl5/vendor_perl/auto/Package/Anon/Anon.so

SHA256-sum check
http://search.cpan.org/CPAN/authors/id/A/AU/AUGGY/Package-Anon-0.05.tar.gz :
  CHECKSUM(SHA256) this package     : 15d0285e628a721138bcb1c36dea934379a89fdbc450fd79148e4e37a77241ba
  CHECKSUM(SHA256) upstream package : 15d0285e628a721138bcb1c36dea934379a89fdbc450fd79148e4e37a77241ba

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 892651

Comment 2 Paul Howarth 2013-01-12 15:43:53 UTC
Thanks for the review Robin.

New Package SCM Request
Package Name: perl-Package-Anon
Short Description: Anonymous packages
Owners: pghmcfc
Branches: f17 f18
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2013-01-13 00:59:03 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2013-01-13 11:04:32 UTC
perl-Package-Anon-0.05-2.fc18 has been submitted as an update for Fedora 18.

Comment 5 Fedora Update System 2013-01-13 11:04:45 UTC
perl-Package-Anon-0.05-2.fc17 has been submitted as an update for Fedora 17.

Comment 6 Fedora Update System 2013-01-14 04:04:36 UTC
perl-Package-Anon-0.05-2.fc18 has been pushed to the Fedora 18 testing repository.

Comment 7 Fedora Update System 2013-01-23 01:24:53 UTC
perl-Package-Anon-0.05-2.fc18 has been pushed to the Fedora 18 stable repository.

Comment 8 Fedora Update System 2013-01-23 01:26:01 UTC
perl-Package-Anon-0.05-2.fc17 has been pushed to the Fedora 17 stable repository.

Note You need to log in before you can comment on or make changes to this bug.