Bug 894107 - Strings from app/views/subscriptions/_edit.html.haml are not being added to app.pot
Summary: Strings from app/views/subscriptions/_edit.html.haml are not being added to a...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Localization and Internationalization
Version: Nightly
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: Unspecified
Assignee: Ivan Necas
QA Contact: Katello QA List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-10 17:57 UTC by Og Maciel
Modified: 2013-12-16 14:23 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-16 14:23:14 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Og Maciel 2013-01-10 17:57:41 UTC
Description of problem:

Looks like all localized strings from app/views/subscriptions/_edit.html.haml are not being added to the app.pot file. Consequently, they're not being translated.

Version-Release number of selected component (if applicable):

* candlepin-0.7.22-1.el6.noarch
* candlepin-selinux-0.7.22-1.el6.noarch
* candlepin-tomcat6-0.7.22-1.el6.noarch
* elasticsearch-0.19.9-4.el6.noarch
* foreman-1.0.2-10.bfa8949.el6.noarch
* foreman-postgresql-1.0.2-10.bfa8949.el6.noarch
* katello-1.3.2-1.git.31.2d91fdc.el6.noarch
* katello-all-1.3.2-1.git.31.2d91fdc.el6.noarch
* katello-candlepin-cert-key-pair-1.0-1.noarch
* katello-certs-tools-1.1.9-1.el6.noarch
* katello-cli-1.3.2-1.git.16.a25efcc.el6.noarch
* katello-cli-common-1.3.2-1.git.16.a25efcc.el6.noarch
* katello-common-1.3.2-1.git.31.2d91fdc.el6.noarch
* katello-configure-1.3.2-1.git.27.d2d0abd.el6.noarch
* katello-glue-candlepin-1.3.2-1.git.31.2d91fdc.el6.noarch
* katello-glue-foreman-1.3.2-1.git.31.2d91fdc.el6.noarch
* katello-glue-pulp-1.3.2-1.git.31.2d91fdc.el6.noarch
* katello-qpid-broker-key-pair-1.0-1.noarch
* katello-qpid-client-key-pair-1.0-1.noarch
* katello-repos-1.3.2-1.el6.noarch
* katello-selinux-1.3.1-1.el6.noarch
* pulp-1.1.12-1.el6.noarch
* pulp-common-1.1.12-1.el6.noarch
* pulp-selinux-server-1.1.12-1.el6.noarch

How reproducible:


Steps to Reproduce:
1. Import a manifest
2. Switch the user locale to pt-BR
3. Visit the Subscriptions page
  
Actual results:

Error message complaining of missing translations

Expected results:


Additional info:

Comment 1 Og Maciel 2013-01-10 17:59:16 UTC
# rpm -qa | grep gettext
rubygem-fast_gettext-0.5.10-2.el6.noarch
gettext-0.17-16.el6.x86_64
rubygem-gettext_i18n_rails-0.2.13-2.el6.noarch

Comment 2 Ivan Necas 2013-01-22 13:13:30 UTC
The problem is new version of ruby_parser doesn't work with old version of gettext_i18n_rails, which leads to haml files not being parsed:

https://github.com/grosser/gettext_i18n_rails/issues/82

The solution would be upgrading to newer gettext_i18n_rails gem (currently 0.9.0), there are however there are some issues with multiline-strings, I'm looking into it right now.

Second option/workaround is downgrading the rubygem-ruby_parser to version:

  rubygem-ruby_parser-2.0.4-3.el6.noarch

Note that foreman (and it's dependency: rubygem-ruby2ruby), needs newer version of ruby_parser, therefore, to extract the pot file, you need to uninstall this gem (and it's dependencies), to downgrade correctly, therefore you need:

  yum remove rubygem-ruby2ruby
  yum downgrade rubygem-ruby_parser rubygem-sexp_processor

Comment 3 Ivan Necas 2013-01-24 09:11:24 UTC
The upstream issue is described and fixed here: 

    https://github.com/grosser/gettext_i18n_rails/pull/88

Waiting for merging my changes and getting new release.

Comment 4 Ivan Necas 2013-01-25 14:47:10 UTC
The fix was accepted by upstream, release in gettext_i18n_rails 0.9.1, after packing this up, we should be able to close this BZ.

https://github.com/grosser/gettext_i18n_rails/pull/88

Comment 6 Bryan Kearney 2013-12-16 14:23:14 UTC
Closing all i18n bus due to ne architecture. The goal is still a localized UI and CLI, but we will do this via a new round of testing.


Note You need to log in before you can comment on or make changes to this bug.