Bug 896583 - rshd fails to close pam sessions correctly when there is no error channel
Summary: rshd fails to close pam sessions correctly when there is no error channel
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rsh
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michal Sekletar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-17 15:05 UTC by Tom Hughes
Modified: 2013-04-30 04:34 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-04-30 04:34:21 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to keep the rsh process around when there is no error channel (491 bytes, patch)
2013-01-17 15:05 UTC, Tom Hughes
no flags Details | Diff

Description Tom Hughes 2013-01-17 15:05:08 UTC
Created attachment 680269 [details]
Patch to keep the rsh process around when there is no error channel

Description of problem:

When an rsh client does no ask for a separate error channel rshd will exec the requested command over the top of itself and will then never be able to close the pam session when the command finishes.

In addition because it then closes all file descriptors (other that 0 to 2) it closes the descriptor that the pam_systemd session module is using which triggers logind to kill the process.

Version-Release number of selected component (if applicable):

rsh-0.17-69.fc18

How reproducible:

Use a client (such as the builtin rsh client in cvs) which does not request an error channel and watch as the server is killed by logind.

Additional info:

Patch attached.

Comment 1 Fedora Admin XMLRPC Client 2013-04-02 13:25:11 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 2 Fedora Update System 2013-04-15 13:45:49 UTC
rsh-0.17-71.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/rsh-0.17-71.fc19

Comment 3 Fedora Update System 2013-04-15 16:20:20 UTC
Package rsh-0.17-71.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing rsh-0.17-71.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-5708/rsh-0.17-71.fc19
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2013-04-30 04:34:23 UTC
rsh-0.17-71.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.