Bug 900364 (JBPAPP6-729) - Future instance returned for the async invocation does not honour javadoc about always returning true after the cancel() is invoked
Summary: Future instance returned for the async invocation does not honour javadoc abo...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: JBPAPP6-729
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: EJB
Version: 6.0.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: EAP 6.0.0
Assignee: Jaikiran Pai
QA Contact:
URL: http://jira.jboss.org/jira/browse/JBP...
Whiteboard: eap6_need_triage
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-05-04 14:05 UTC by Ondrej Chaloupka
Modified: 2014-06-28 12:33 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-08 00:12:44 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker JBPAPP6-729 0 None None None Never

Description Ondrej Chaloupka 2012-05-04 14:05:26 UTC
Affects: Release Notes
project_key: JBPAPP6

After method cancel() returns, subsequent calls to isDone() should always return true.

The server side implementation of the Future instance returned for the async invocation has a bug in the isDone() method since it doesn't honour the requirements set by the isDone() javadoc about always returning true after the cancel() is invoked.

Please, see the comment https://issues.jboss.org/browse/EJBCLIENT-28?focusedCommentId=12690373&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12690373
On jira EJBCLIENT-28.

The testcase could be checked here:
https://github.com/ochaloup/jboss-as/blob/async-method-cancel-invocation/testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/async/AsyncMethodTestCase.java#L184

Comment 1 Ondrej Chaloupka 2012-05-04 14:18:58 UTC
Link: Added: This issue is related to EJBCLIENT-28


Comment 2 Rajesh Rajasekaran 2012-05-04 15:10:37 UTC
Labels: Added: eap6_need_triage


Comment 3 Jaikiran Pai 2012-05-07 14:07:53 UTC
Pull request sent https://github.com/jbossas/jboss-as/pull/2246


Comment 4 Shelly McGowan 2012-05-07 17:56:20 UTC
Marking for CR1 and will verify it was brought in.

Comment 5 Jaikiran Pai 2012-05-08 07:44:03 UTC
This made it to AS7 upstream this morning. Marking this as resolved.


Comment 6 Ondrej Chaloupka 2012-05-18 12:41:28 UTC
Verified on ER8.

Comment 7 Misty Stanley-Jones 2012-06-01 05:03:39 UTC
Reopening for release note

Comment 8 Misty Stanley-Jones 2012-06-01 05:04:01 UTC
Release Notes Docs Status: Added: Not Yet Documented
Affects: Added: Release Notes


Comment 9 Ondrej Chaloupka 2012-06-05 22:45:37 UTC
Verified on CR1 - org.jboss.as.test.integration.ejb.async.AsyncMethodTestCase.testCancelAsyncMethod() passed

Comment 10 Tom WELLS 2012-06-08 00:12:28 UTC
Release Notes Docs Status: Removed: Not Yet Documented Added: Documented as Resolved Issue
Release Notes Text: Added: The server side implementation of the Future instance returned for an asychronous EJB method invocation had a flaw in the isDone() method. As a result, the isDone() method on an EJB was not always returning true when the cancel() method was called asynchronously. The isDone() method now properly registers an asychronous call to cancel(), and always returns true after cancel() has been called.


Comment 11 Anne-Louise Tangring 2012-11-05 17:51:02 UTC
Release Notes Docs Status: Removed: Documented as Resolved Issue 
Release Notes Text: Removed: The server side implementation of the Future instance returned for an asychronous EJB method invocation had a flaw in the isDone() method. As a result, the isDone() method on an EJB was not always returning true when the cancel() method was called asynchronously. The isDone() method now properly registers an asychronous call to cancel(), and always returns true after cancel() has been called. 
Docs QE Status: Removed: NEW 



Note You need to log in before you can comment on or make changes to this bug.