Spec URL: http://mtasaka.fedorapeople.org/Review_request/wkhtmltopdf/wkhtmltopdf.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/wkhtmltopdf/wkhtmltopdf-0.11.0-0.1.rc1.fc.src.rpm Description: Simple shell utility to convert html to pdf using the webkit rendering engine, and qt. Fedora Account System Username: mtasaka Koji scratch build F-19: http://koji.fedoraproject.org/koji/taskinfo?taskID=4948714 F-18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4948732
Review: + koji build used http://koji.fedoraproject.org/koji/taskinfo?taskID=4948714 + rpmlint on rpms gave wkhtmltopdf.src: W: spelling-error Summary(en_US) html -> HTML, ht ml, ht-ml wkhtmltopdf.src: W: spelling-error Summary(en_US) pdf -> pd, pf, pd f wkhtmltopdf.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml wkhtmltopdf.src: W: spelling-error %description -l en_US pdf -> pd, pf, pd f wkhtmltopdf.src: W: spelling-error %description -l en_US webkit -> web kit, web-kit, website wkhtmltopdf.src: W: invalid-url Source0: http://wkhtmltopdf.googlecode.com/files/wkhtmltopdf-0.11.0_rc1.tar.bz2 HTTP Error 404: Not Found wkhtmltopdf.x86_64: W: spelling-error Summary(en_US) html -> HTML, ht ml, ht-ml wkhtmltopdf.x86_64: W: spelling-error Summary(en_US) pdf -> pd, pf, pd f wkhtmltopdf.x86_64: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml wkhtmltopdf.x86_64: W: spelling-error %description -l en_US pdf -> pd, pf, pd f wkhtmltopdf.x86_64: W: spelling-error %description -l en_US webkit -> web kit, web-kit, website wkhtmltopdf.x86_64: W: no-manual-page-for-binary wkhtmltoimage wkhtmltopdf.x86_64: W: no-manual-page-for-binary wkhtmltopdf wkhtmltopdf-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 14 warnings. ==> Warnings can be ignored + Source verified with upstream as http://wkhtmltopdf.googlecode.com/files/wkhtmltopdf-0.11.0_rc1.tar.bz2 : CHECKSUM(SHA256) this package : a36dbfc7cc27604b667f278ff8e9c86ced6777cdd1646d585d4e06e473b1905c CHECKSUM(SHA256) upstream package : a36dbfc7cc27604b667f278ff8e9c86ced6777cdd1646d585d4e06e473b1905c + License is GPLv3+ and included in COPYING as well as individual source headers. suggestions: 1) Can examples be included in %doc? APPROVED
Thank you for review! If you want swap review, please let me know it. (In reply to comment #1) > suggestions: > 1) Can examples be included in %doc? I will include this to -devel (because these examples are how to use wkhtmltopdf API) New Package SCM Request ======================= Package Name: wkhtmltopdf Short Description: Simple shell utility to convert html to pdf Owners: mtasaka Branches: f18 f17 InitialCC:
Git done (by process-git-requests).
Built successfully on F-19/18/17, push requested on F-18/17, now closing. Thank you for review and git procedure!
Package Change Request ====================== Package Name: wkhtmltopdf New Branches: el6-docs Owners: rlandmann [FYI, Tasaka-san, I am requesting this branch because the Fedora docs project would like to use a version of wkhtmltopdf built against QT just for the docs on the Fedora website. See also my separate review request for the customised QT package here: https://bugzilla.redhat.com/show_bug.cgi?id=955996 ]
Invalid branch, can has Mamoru OKd this?
(In reply to Ruediger Landmann from comment #5) [FYI, Tasaka-san, I am requesting this branch because the Fedora docs > project would like to use a version of wkhtmltopdf built against QT just for > the docs on the Fedora website. See also my separate review request for the > customised QT package here: > https://bugzilla.redhat.com/show_bug.cgi?id=955996 ] Do you want to use wkhtmltopdf-qt on EL6? (I don't know what is EL6-docs branch). If so, I will wait until how qt maintainers think of this (see bug 955996 comment 2)
Package Change Request ====================== Package Name: wkhtmltopdf New Branches: epel7 Owners: lkundrak The Fedora maintainer is unfortunately not maintaining EPEL packages: http://fedoraproject.org/wiki/EPEL/ContributorStatusNo