Red Hat Bugzilla – Bug 91852
incorrect line counting for output reports
Last modified: 2007-04-18 12:54:06 EDT
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20030113
Description of problem:
There are several logic errors in xferstats-2.16/display.c which affect the
counting of output lines for the reports. Most affect the daily report, while
one affects multiple other reports.
In most cases, the errors are of the "off by one" variety. In one case, the
logic is very confusing and just plain wrong.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Set "NUMBER_DAILY_STATS 90" and "DAILY_SORT_PREF 2" in /etc/xferstats.cfg
2. Run xferstats with more than 90 days worth of xferlog data.
3. View the resulting daily.html output.
Actual Results: The output will contain one less line than it should.
Furthermore, the number of entries per output table (30 by default) will not be
respected - all entries will be in one table.
For other reports, the line count will only be correct for the first table, then
be off by one for subsequent tables.
Expected Results: Output line counts should be as requested, or as advertized
Created attachment 92043 [details]
patch to correct multiple bugs related to output line counts
2.16-7 has this fix. Thanks for your patch file.