Spec URL: http://leamas.fedorapeople.org/supybot-git/1/supybot-git.spec SRPM URL: http://leamas.fedorapeople.org/supybot-git/1/supybot-git-0-1.179fa8b.fc17.src.rpm Fedora Account System Username:leamas Description A supybot plugin providing info from git repositories on IRC channels. Main features: * Notifies IRC channel of new commits. * Reports info on commit SHA:s mentioned in IRC conversations. * Display a log of recent commits on command. * Monitor as many repository/branch combinations as you like. * Privacy: repositories are associated with a channel and cannot be seen from other channels. * Highly configurable.
Updated links: spec:http://leamas.fedorapeople.org/supybot-git/2/supybot-git.spec srpm: http://leamas.fedorapeople.org/supybot-git/2/supybot-git-0-2.93b25be.fc18.src.rpm
Taking this.
tl;dr: LGTM, ship it. Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated ===== Issues (1 minor one) ===== > [x]: If the source package does not include license text(s) as a separate file > from upstream, the packager SHOULD query upstream to include it. I'm aware that you are both packager and upstream, so please consider adding a LICENSE file to your project =). Not a blocker, though. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [-]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 1 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: supybot-git-0-2.93b25be.fc16.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint supybot-git supybot-git.noarch: I: enchant-dictionary-not-found en_US 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- supybot-git (rpmlib, GLIBC filtered): GitPython python(abi) supybot Provides -------- supybot-git: supybot-git MD5-sum check ------------- https://github.com/leamas/supybot-git/archive/93b25be6f6b720f5692c25c7b16964f9f1407635/supybot-git-0-93b25be.tar.gz : CHECKSUM(SHA256) this package : f960efbe5dd8dfeca80296508e117bb3d1d30505db819e72ae61fd7612712d65 CHECKSUM(SHA256) upstream package : f960efbe5dd8dfeca80296508e117bb3d1d30505db819e72ae61fd7612712d65 Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-16-x86_64 Command line :/bin/fedora-review -b 919645
Thanks for review! And also thanks for the license file reminder, I'll fix that!
New Package SCM Request ======================= Package Name: supybot-git Short Description: Git repository info IRC bot Owners: leamas Branches: f17 f18 InitialCC:
Git done (by process-git-requests).
devel, f17, f18 built OK. Closing.