Created attachment 712978 [details] Patch for fedora-release spec fedora-release shouldn't contain special characters. Check for a bunch of them during build and abort if they're there.
im not going to apply this patch
Why not? Including any of these characters would be an error, and guarding against them being accidentally included in the release seems worthwhile.
<t8m> #agreed Release name must not contain any shell metacharacters. (+5, -3, 0:1) So since we've agreed to not allow these, this is a reasonable check we should include in the build process.
(In reply to comment #3) > <t8m> #agreed Release name must not contain any shell metacharacters. (+5, > -3, 0:1) > > So since we've agreed to not allow these, this is a reasonable check we > should include in the build process. Since it is a check, it belongs to %check and not %build. Also the check is missing other metacharacters such as space or tab. And there seem to be characters included that are no metacharacters at least wrt parameter expansion, such as ^, :, %, @ and =. IMHO the the naming guideline should therefore explicitly state which characters are forbidden and then the list should be used to create a proper check. According to bash(1) even ' is not a metacharacter: DEFINITIONS [...] metacharacter A character that, when unquoted, separates words. One of the following: | & ; ( ) < > space tab And the message in the check should clearly say that an error occured.
Well, it seems we've been slightly less strict in our use of the word of "metacharacters" than we should have been. Space and tab are clearly okay, and single or double quotes clearly aren't. So the language we agreed on is unfortunate, to be sure :(
Hmm, so what's the conclusion for the Fedora 19 release name? Now /etc/issue is Schrödinger’s Cat which doesn't display correctly in the console. If you change the ’ to a ', it works.
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle. Changing version to '20'. More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20
Patch has been applied awhile ago, cleaning up the bug report