Bug 926050 - Constant fields that are not final
Summary: Constant fields that are not final
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Server
Version: 6.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ER7
: EAP 6.2.0
Assignee: Brian Stansberry
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-23 13:05 UTC by Brian Stansberry
Modified: 2013-12-15 16:17 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-15 16:17:03 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
list of non-final constants (25.81 KB, text/plain)
2013-03-23 13:05 UTC, Brian Stansberry 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker AS7-6781 0 Major Resolved Constant fields that are not final 2014-03-17 03:09:01 UTC

Description Brian Stansberry 2013-03-23 13:05:46 UTC 
Created attachment 715073 [details]
list of non-final constants

Analysis by Stephan Mueller shows that the AS codebase includes a significant number of public constant fields that are missing the "final" keyword, which could allow incorrect or nefarious code to change them. This task is to fix these.
As part of the work for a few cases I'll reduce the field visibility.
Comment 3 Rostislav Svoboda 2013-04-25 14:10:45 UTC 
PR is ready - https://github.com/jbossas/jboss-eap/pull/73

setting blocker flag to get this change to EAP 6.1.0
Comment 6 Rostislav Svoboda 2013-04-29 07:02:53 UTC 
Removing blocker flag based on Brian's comment.
Comment 13 Ladislav Thon 2013-11-14 14:30:52 UTC 
Verified with EAP 6.2.0.CR1. Only checked that the commit is present in the CR1 tag and that some of the changes from the commit are actually in the CR1-src.zip.
Note You need to log in before you can comment on or make changes to this bug.