Created attachment 732575 [details] [PATCH] Fix "cvs rm -f" completion Hi, I've decide to go dogfood F-19 in stock configuration, which means with bash-completion installed. I used to always uninstall it since it hindered me as often as it helped. But now I've opted to instead every time it does not work as I want to fix it. So this is the first patch in what likely will be a long series of patches. I should probably also file these directly upstream, but I'm lazy, and don't know the procedure fir filing upstream bugs for this, if you can tell me how to do that I'll happily also file upstream. Now on to the patch, the "cvs rm" completion checks for files which are listed in CVS's Entries file, but not actually present. This is the right thing to do when someone does: "rm foo; cvs rm foo" but there is a shorthand for that in the form of "cvs rm -f foo" which will both actually remove the file from the filesystem and from the Entries file. So in the -f case there should be no check for the file being present on the filesystem. Regards, Hans
(In reply to comment #0) > I should probably also file these directly upstream, but I'm lazy, and don't > know the procedure fir filing upstream bugs for this, Thanks in advance. See CONTRIBUTING in /usr/share/doc/bash-completion-*/README, in a nutshell: generate patches against current upstream git master, use "git format-patch" to format them, and either send them to the bash-completion ML (subscription needed) with, or submit+attach them to the tracker at https://alioth.debian.org/tracker/?atid=413095&group_id=100114&func=browse > if you can tell me how to do that I'll happily also file upstream. No need to _also_ file there; either here or there is fine, no need for both. But preferably upstream unless the issue is Fedora specific.
Hi, (In reply to comment #1) > No need to _also_ file there; either here or there is fine, no need for > both. But preferably upstream unless the issue is Fedora specific. Ok, so I assume you will take care if this patch? I'll file future patches upstream as described in the README. Thanks, Hans
(In reply to comment #2) > Ok, so I assume you will take care if this patch? Sure, slightly different version applied upstream: http://anonscm.debian.org/gitweb/?p=bash-completion/bash-completion.git;a=commitdiff;h=9852597
bash-completion-2.1-6.20141110git52d8316.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/bash-completion-2.1-6.20141110git52d8316.fc21
Package bash-completion-2.1-6.20141110git52d8316.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing bash-completion-2.1-6.20141110git52d8316.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-14732/bash-completion-2.1-6.20141110git52d8316.fc21 then log in and leave karma (feedback).
bash-completion-2.1-6.20141110git52d8316.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.