Description of problem: ======================================================== Each time you attempt to upload a image, the existing log file gets overwritten which makes debugging issues harder when you execute multiple attempts to upload. Either append or save existing off to a timestamp prefixed file would be a little more customer friendly. Version-Release number of selected component (if applicable): ==================================================================== rhevm-image-uploader-3.1.0-7.el6ev.noarch How reproducible: ================ 100% Steps to Reproduce: ================================== 1. run several uploads in succession and see the log file only tracks the last attempt
Patch pushed on master branch. Note that also log-collector and iso-uploader are affected by the same bug. I'll open one bug for each of them.
Log messages to timestamped files as default, avoiding to overwrite existing ones. The default location of the logs was changed, to improve /var/log/ovirt-engine sanity. /var/log/ovirt-engine -> /var/log/ovirt-engine/ovirt-image-uploader A log rotation was introduced in order to compress old logs.
merged upstream master, pushed to 3.3 branch
merged upstream 3.3 branch
3.3/is11 I get a new file for each image-uploader command is this correct ? ======================= >ovirt-image-uploader-20130827113507.log 2013-08-27 11:35:18::ERROR::rhevm-image-uploader::1335::root:: not a gzip file >ovirt-image-uploader-20130827120229.log 2013-08-27 12:02:40::ERROR::rhevm-image-uploader::1335::root:: empty header -rw-r--r--. 1 root root 192 Aug 27 11:09 ovirt-image-uploader-20130827110954.log -rw-r--r--. 1 root root 192 Aug 27 11:11 ovirt-image-uploader-20130827111114.log -rw-r--r--. 1 root root 192 Aug 27 11:11 ovirt-image-uploader-20130827111131.log -rw-r--r--. 1 root root 192 Aug 27 11:11 ovirt-image-uploader-20130827111133.log -rw-r--r--. 1 root root 192 Aug 27 11:11 ovirt-image-uploader-20130827111135.log -rw-r--r--. 1 root root 192 Aug 27 11:11 ovirt-image-uploader-20130827111136.log -rw-r--r--. 1 root root 99 Aug 27 11:12 ovirt-image-uploader-20130827111242.log -rw-r--r--. 1 root root 0 Aug 27 11:16 ovirt-image-uploader-20130827111602.log -rw-r--r--. 1 root root 209 Aug 27 11:17 ovirt-image-uploader-20130827111750.log -rw-r--r--. 1 root root 0 Aug 27 11:17 ovirt-image-uploader-20130827111757.log -rw-r--r--. 1 root root 110 Aug 27 11:18 ovirt-image-uploader-20130827111845.log -rw-r--r--. 1 root root 79 Aug 27 11:35 ovirt-image-uploader-20130827113507.log -rw-r--r--. 1 root root 76 Aug 27 12:02 ovirt-image-uploader-20130827120229.log -rw-r--r--. 1 root root 109 Aug 27 12:04 ovirt-image-uploader-20130827120434.log -rw-r--r--. 1 root root 76 Aug 27 12:05 ovirt-image-uploader-20130827120456.log -rw-r--r--. 1 root root 76 Aug 27 12:05 ovirt-image-uploader-20130827120528.log
(In reply to David Botzer from comment #6) > 3.3/is11 > I get a new file for each image-uploader command is this correct ? Yes a new log file is created for each image-uploader execution. It is correct.
Fixed, 3.3/is11
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-0078.html