Bug 951228 - Systems Custom Information - Keyname and value needs to enforce maximum length restrictions
Summary: Systems Custom Information - Keyname and value needs to enforce maximum lengt...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: WebUI
Version: Nightly
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: Unspecified
Assignee: Adam Price
QA Contact: Og Maciel
URL:
Whiteboard:
: 970463 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-11 17:25 UTC by sthirugn@redhat.com
Modified: 2019-09-26 15:50 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-07-18 21:18:04 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Exception when keyname is greater than 255 characters (96.33 KB, image/png)
2013-04-11 17:25 UTC, sthirugn@redhat.com
no flags Details

Description sthirugn@redhat.com 2013-04-11 17:25:47 UTC
Created attachment 734353 [details]
Exception when keyname is greater than 255 characters

Description of problem:
Adding a Keyname or value more than 255 characters throws an exception in the UI.  Keyname and value needs to enforce maximum length restrictions

Version-Release number of selected component (if applicable):
* candlepin-0.8.2-1.el6.noarch
* candlepin-selinux-0.8.2-1.el6.noarch
* candlepin-tomcat6-0.8.2-1.el6.noarch
* elasticsearch-0.19.9-7.el6.noarch
* foreman-1.1stable-10.6ce2ab7.el6.noarch
* foreman-postgresql-1.1stable-10.6ce2ab7.el6.noarch
* katello-1.3.14-1.git.1139.53323b7.el6.noarch
* katello-all-1.3.14-1.git.1139.53323b7.el6.noarch
* katello-candlepin-cert-key-pair-1.0-1.noarch
* katello-certs-tools-1.3.0-1.git.2847.9dfcc69.el6.noarch
* katello-cli-1.3.5-1.git.202.7f13583.el6.noarch
* katello-cli-common-1.3.5-1.git.202.7f13583.el6.noarch
* katello-common-1.3.14-1.git.1139.53323b7.el6.noarch
* katello-configure-1.3.6-1.git.1155.2a1db01.el6.noarch
* katello-glue-candlepin-1.3.14-1.git.1139.53323b7.el6.noarch
* katello-glue-elasticsearch-1.3.14-1.git.1139.53323b7.el6.noarch
* katello-glue-foreman-1.3.14-1.git.1139.53323b7.el6.noarch
* katello-glue-pulp-1.3.14-1.git.1139.53323b7.el6.noarch
* katello-qpid-broker-key-pair-1.0-1.noarch
* katello-qpid-client-key-pair-1.0-1.noarch
* katello-repos-1.3.2-1.git.2025.9dfcc69.el6.noarch
* katello-selinux-1.3.1-1.git.1803.9dfcc69.el6.noarch
* pulp-rpm-plugins-2.1.0-0.noarch
* pulp-selinux-2.1.0-0.n

How reproducible:
Always

Steps to Reproduce:
1. Register a client
2. Navigate to UI -> Systems page -> Select a registered system -> Details Tab -> Custom Information
3. Enter keyname with length more than 255 characters
  
Actual results:
An exception is thrown. Screenshot attached.  
Note: The same is observed for the value field as well.

Expected results:
Error message should be thrown to the user saying the maximum length allowed is 255 characters

Additional info:
The same issue is observed with the value field as well

Comment 1 sthirugn@redhat.com 2013-05-21 19:05:46 UTC
This bug is also observed in 
1. Administer -> Organizations -> Select an ORG -> Default Custom Info -> System Default Info
2. Administer -> Organizations -> Select an ORG -> Default Custom Info -> Distributor Default Info
3. Content -> Subscriptions -> Subscription Manager Applications -> Select a Distributor -> Details -> Custom Information -> 

Note to QE: Please these scenarios also along with Bug verification

Comment 3 Adam Price 2013-05-31 19:06:49 UTC
https://github.com/Katello/katello/pull/2363

Comment 5 Adam Price 2013-06-12 20:54:23 UTC
*** Bug 970463 has been marked as a duplicate of this bug. ***

Comment 6 Brad Buckingham 2013-06-13 15:44:30 UTC
Per discussion with QE adding sat6.0.1 flag.

Comment 8 Brad Buckingham 2013-06-15 00:08:43 UTC
Mass move to ON_QA

Comment 9 Og Maciel 2013-06-17 14:31:31 UTC
Validation works when creating the custom keyname/value but you can update it later and add more than 255 characters.

Verified:
* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.8.9-1.el6_4.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.8.9-1.el6_4.noarch
* candlepin-tomcat6-0.8.9-1.el6_4.noarch
* elasticsearch-0.19.9-8.el6sat.noarch
* foreman-1.1.10011-1.noarch
* foreman-compute-1.1.10011-1.noarch
* foreman-installer-puppet-concat-0-2.d776701.git.0.21ef926.el6sat.noarch
* foreman-installer-puppet-dhcp-0-5.3a4a13c.el6sat.noarch
* foreman-installer-puppet-dns-0-7.fcae203.el6sat.noarch
* foreman-installer-puppet-foreman-0-6.568c5c4.el6sat.noarch
* foreman-installer-puppet-foreman_proxy-0-8.bd1e35d.el6sat.noarch
* foreman-installer-puppet-puppet-0-3.ab46748.el6sat.noarch
* foreman-installer-puppet-tftp-0-5.ea6c5e5.el6sat.noarch
* foreman-installer-puppet-xinetd-0-50a267b8.git.0.44aca6a.el6sat.noarch
* foreman-libvirt-1.1.10011-1.noarch
* foreman-postgresql-1.1.10011-1.noarch
* foreman-proxy-1.1.10003-1.el6sat.noarch
* foreman-proxy-installer-1.0.1-10.f5ae2cd.el6sat.noarch
* katello-1.4.2-14.el6sat.noarch
* katello-all-1.4.2-14.el6sat.noarch
* katello-candlepin-cert-key-pair-1.0-1.noarch
* katello-certs-tools-1.4.2-2.el6sat.noarch
* katello-cli-1.4.2-7.el6sat.noarch
* katello-cli-common-1.4.2-7.el6sat.noarch
* katello-common-1.4.2-14.el6sat.noarch
* katello-configure-1.4.3-16.el6sat.noarch
* katello-configure-foreman-1.4.3-16.el6sat.noarch
* katello-foreman-all-1.4.2-14.el6sat.noarch
* katello-glue-candlepin-1.4.2-14.el6sat.noarch
* katello-glue-elasticsearch-1.4.2-14.el6sat.noarch
* katello-glue-pulp-1.4.2-14.el6sat.noarch
* katello-qpid-broker-key-pair-1.0-1.noarch
* katello-qpid-client-key-pair-1.0-1.noarch
* katello-selinux-1.4.3-3.el6sat.noarch
* openldap-2.4.23-31.el6.x86_64
* pulp-rpm-plugins-2.1.2-0.3.beta.el6sat.noarch
* pulp-selinux-2.1.2-0.3.beta.el6sat.noarch
* pulp-server-2.1.2-0.3.beta.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-ldap_fluff-0.2.2-1.el6sat.noarch
* ruby193-rubygem-net-ldap-0.3.1-2.el6sat.noarch
* signo-0.0.18-1.el6sat.noarch
* signo-katello-0.0.18-1.el6sat.noarch

Comment 10 Mike McCune 2013-06-18 21:36:52 UTC
For me it wouldn't let me update to 255 characters.  the save failed and you are left with the original value.

That said, we should still raise an error message like we do on create.  Adam will address this

Comment 11 Adam Price 2013-06-20 14:36:00 UTC
https://github.com/Katello/katello/pull/2529

Comment 12 Adam Price 2013-06-20 14:37:33 UTC
added a trello card (https://trello.com/c/dHMlIRks) to address notifications for actions across the entire application as opposed to notifications only existing in the web UI.

Comment 14 Brad Buckingham 2013-06-21 12:59:36 UTC
Mass move to ON_QA

Comment 15 Og Maciel 2013-06-22 02:28:50 UTC
Verified:
* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.8.9-1.el6_4.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.8.9-1.el6_4.noarch
* candlepin-tomcat6-0.8.9-1.el6_4.noarch
* elasticsearch-0.19.9-8.el6sat.noarch
* foreman-1.1.10014-1.noarch
* foreman-compute-1.1.10014-1.noarch
* foreman-installer-puppet-concat-0-2.d776701.git.0.21ef926.el6sat.noarch
* foreman-installer-puppet-dhcp-0-5.3a4a13c.el6sat.noarch
* foreman-installer-puppet-dns-0-7.fcae203.el6sat.noarch
* foreman-installer-puppet-foreman-0-6.568c5c4.el6sat.noarch
* foreman-installer-puppet-foreman_proxy-0-8.bd1e35d.el6sat.noarch
* foreman-installer-puppet-puppet-0-3.ab46748.el6sat.noarch
* foreman-installer-puppet-tftp-0-5.ea6c5e5.el6sat.noarch
* foreman-installer-puppet-xinetd-0-50a267b8.git.0.44aca6a.el6sat.noarch
* foreman-libvirt-1.1.10014-1.noarch
* foreman-postgresql-1.1.10014-1.noarch
* foreman-proxy-1.1.10003-1.el6sat.noarch
* foreman-proxy-installer-1.0.1-10.f5ae2cd.el6sat.noarch
* katello-1.4.2-17.el6sat.noarch
* katello-all-1.4.2-17.el6sat.noarch
* katello-candlepin-cert-key-pair-1.0-1.noarch
* katello-certs-tools-1.4.2-2.el6sat.noarch
* katello-cli-1.4.2-8.el6sat.noarch
* katello-cli-common-1.4.2-8.el6sat.noarch
* katello-common-1.4.2-17.el6sat.noarch
* katello-configure-1.4.3-16.el6sat.noarch
* katello-configure-foreman-1.4.3-16.el6sat.noarch
* katello-foreman-all-1.4.2-17.el6sat.noarch
* katello-glue-candlepin-1.4.2-17.el6sat.noarch
* katello-glue-elasticsearch-1.4.2-17.el6sat.noarch
* katello-glue-pulp-1.4.2-17.el6sat.noarch
* katello-qpid-broker-key-pair-1.0-1.noarch
* katello-qpid-client-key-pair-1.0-1.noarch
* katello-selinux-1.4.3-3.el6sat.noarch
* openldap-2.4.23-31.el6.x86_64
* pulp-rpm-plugins-2.1.2-1.el6sat.noarch
* pulp-selinux-2.1.2-1.el6sat.noarch
* pulp-server-2.1.2-1.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-ldap_fluff-0.2.2-1.el6sat.noarch
* ruby193-rubygem-net-ldap-0.3.1-2.el6sat.noarch
* ruby193-rubygem-runcible-0.4.10-1.el6sat.noarch
* signo-0.0.19-1.el6sat.noarch
* signo-katello-0.0.19-1.el6sat.noarch

Comment 16 Mike McCune 2013-07-18 21:18:04 UTC
mass move to CLOSED:CURRENTRELEASE since MDP1 has been released.


Note You need to log in before you can comment on or make changes to this bug.