This function in lib/cluster.c does not check the realloc return value: static void cluster_add_index(struct cluster *cluster, int index) { if (cluster->size >= cluster->alloced) { cluster->alloced = cluster->alloced >= 1 ? cluster->alloced * 2 : 1; cluster->objects = realloc(cluster->objects, sizeof (*cluster->objects) * cluster->alloced); } cluster->objects[cluster->size++] = index; } I think you generally abort on memory allocation failure (via the btp_* wrappers), so you should do this here as well.
Patch posted for review, thanks for the report. https://lists.fedorahosted.org/pipermail/crash-catcher/2013-April/004298.html
(In reply to comment #1) > Patch posted for review, thanks for the report. > > https://lists.fedorahosted.org/pipermail/crash-catcher/2013-April/004298.html Thanks. I think it would make sense to split out the element size and array length into separate arguments, so that you can perform the overflow check in a central location. lib/cluster.c lacks overflow checks in array allocations in various places (btp_dendrogram_new, btp_cluster_new, cluster_add_index). lib/metrics.c:btp_distances_new() is also affected.
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle. Changing version to '20'. More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20
Here's another attempt to fix this: https://github.com/abrt/satyr/pull/138/files
This message is a reminder that Fedora 20 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 20. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '20'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 20 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 20 changed to end-of-life (EOL) status on 2015-06-23. Fedora 20 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.