Spec URL: http://labs.linuxnetz.de/bugzilla/perl-Spreadsheet-XLSX.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/perl-Spreadsheet-XLSX-0.13-1.src.rpm Description: The Spreadsheet::XLSX module is a emulation of Spreadsheet::ParseExcel for Excel 2007 (.xlsx) file format in a quick and dirty way. It supports styles and many of the Excel's quirks, but not all. It populates the classes from Spreadsheet::ParseExcel for interoperability; including workbook, worksheet and cell. This package will be imported to EPEL 5 and 6 and of course to all active Fedora branches.
URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: 63a63b6eebb59c941c5394cc087748e9219c57055f8cfc2eaa7c3939a1e67be5). Ok. Patches are good. Ok. Summary verified from README. Ok. Description verified from lib/Spreadsheet/XLSX.pm. Ok. No XS code, noarch BuilArch is Ok. License verified from README and lib/Spreadsheet/XLSX.pm. Ok. FIX: Build-require `perl(ExtUtils::MakeMaker)' (Makefile.PL:2). FIX: Build-require `perl(Data::Dumper)' for running tests (lib/Spreadsheet/XLSX.pm:13). FIX: Build-require `perl(Exporter)' for running tests (lib/Spreadsheet/XLSX/Utility2007.pm:12). FIX: Build-require `perl(Test::More)' for running tests (t/2_____with_chart.t:1). TODO: You can use plain `perl' instead of macro `%{__perl}'. BuildRoot code is for EPEL-5. Ok. TODO: You can replace `PERL_INSTALL_ROOT' with `DESTDIR' argument in %install section. TODO: You can remove explicit %defattr definition in %files sectinos. All tests pass. Ok. $ rpmlint perl-Spreadsheet-XLSX.spec ../SRPMS/perl-Spreadsheet-XLSX-0.13-1.fc20.src.rpm ../RPMS/noarch/perl-Spreadsheet-XLSX-0.13-1.fc20.noarch.rpm perl-Spreadsheet-XLSX.src: W: spelling-error %description -l en_US ParseExcel -> Parse Excel, Parse-excel, Paracelsus perl-Spreadsheet-XLSX.src: W: spelling-error %description -l en_US interoperability -> interchangeability, invulnerability, inseparability perl-Spreadsheet-XLSX.noarch: W: spelling-error %description -l en_US ParseExcel -> Parse Excel, Parse-excel, Paracelsus perl-Spreadsheet-XLSX.noarch: W: spelling-error %description -l en_US interoperability -> interchangeability, invulnerability, inseparability 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Spreadsheet-XLSX-0.13-1.fc20.noarch.rpm drwxr-xr-x 2 root root 0 May 9 15:52 /usr/share/doc/perl-Spreadsheet-XLSX-0.13 -rw-r--r-- 1 root root 2143 May 16 2010 /usr/share/doc/perl-Spreadsheet-XLSX-0.13/Changes -rw-r--r-- 1 root root 604 Jul 4 2008 /usr/share/doc/perl-Spreadsheet-XLSX-0.13/README -rw-r--r-- 1 root root 3225 May 9 15:52 /usr/share/man/man3/Spreadsheet::XLSX.3pm.gz -rw-r--r-- 1 root root 2070 May 9 15:52 /usr/share/man/man3/Spreadsheet::XLSX::Fmt2007.3pm.gz -rw-r--r-- 1 root root 3297 May 9 15:52 /usr/share/man/man3/Spreadsheet::XLSX::Utility2007.3pm.gz drwxr-xr-x 2 root root 0 May 9 15:52 /usr/share/perl5/vendor_perl/Spreadsheet drwxr-xr-x 2 root root 0 May 9 15:52 /usr/share/perl5/vendor_perl/Spreadsheet/XLSX -rw-r--r-- 1 root root 8422 May 9 15:52 /usr/share/perl5/vendor_perl/Spreadsheet/XLSX.pm -rw-r--r-- 1 root root 5487 May 16 2010 /usr/share/perl5/vendor_perl/Spreadsheet/XLSX/Fmt2007.pm -rw-r--r-- 1 root root 37046 May 16 2010 /usr/share/perl5/vendor_perl/Spreadsheet/XLSX/Utility2007.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Spreadsheet-XLSX-0.13-1.fc20.noarch.rpm | sort | uniq -c 1 perl >= 0:5.006000 1 perl(Archive::Zip) 1 perl(Data::Dumper) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.3) 1 perl(Spreadsheet::ParseExcel) 1 perl(Spreadsheet::XLSX::Fmt2007) 1 perl(Spreadsheet::XLSX::Utility2007) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Spreadsheet-XLSX-0.13-1.fc20.noarch.rpm | sort | uniq -c 1 perl(Spreadsheet::XLSX) = 0.13 1 perl-Spreadsheet-XLSX = 0.13-1.fc20 1 perl(Spreadsheet::XLSX::Fmt2007) = 0.13 1 perl(Spreadsheet::XLSX::Utility2007) = 0.13 Binary provides are Ok. Package does not build in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5354415). FIX: Declare all the build-time dependencies. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved.
Petr, thank you very much for the efforts. I have applied all suggested changes. Spec URL: http://labs.linuxnetz.de/bugzilla/perl-Spreadsheet-XLSX.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/perl-Spreadsheet-XLSX-0.13-2.src.rpm
Spec file changes: --- perl-Spreadsheet-XLSX.spec.old 2013-04-16 18:08:44.000000000 +0200 +++ perl-Spreadsheet-XLSX.spec 2013-05-09 17:07:03.000000000 +0200 @@ -3,7 +3,7 @@ Summary: Perl extension for reading Microsoft Excel 2007 files Name: perl-Spreadsheet-XLSX Version: 0.13 -Release: 1%{?dist} +Release: 2%{?dist} License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/%{pkgname}/ @@ -12,6 +12,8 @@ Patch1: perl-Spreadsheet-XLSX-0.13-warnings.patch Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) BuildRequires: perl(Archive::Zip) >= 1.16, perl(Spreadsheet::ParseExcel) +BuildRequires: perl(ExtUtils::MakeMaker), perl(Data::Dumper), perl(Exporter) +BuildRequires: perl(Test::More) BuildArch: noarch BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) @@ -31,12 +33,12 @@ chmod 644 Changes README lib/Spreadsheet/{*,*/*}.pm %build -%{__perl} Makefile.PL INSTALLDIRS=vendor +perl Makefile.PL INSTALLDIRS=vendor make %{?_smp_mflags} %install rm -rf $RPM_BUILD_ROOT -make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +make pure_install DESTDIR=$RPM_BUILD_ROOT find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';' find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';' @@ -49,12 +51,14 @@ rm -rf $RPM_BUILD_ROOT %files -%defattr(-,root,root,-) %doc Changes README %{perl_vendorlib}/Spreadsheet/ %{_mandir}/man3/*.3pm* %changelog +* Thu May 09 2013 Robert Scheck <robert> 0.13-2 +- Changes to match with Fedora Packaging Guidelines (#952796) + * Tue Apr 16 2013 Robert Scheck <robert> 0.13-1 - Upgrade to 0.13 - Initial spec file for Fedora and Red Hat Enterprise Linux > FIX: Build-require `perl(ExtUtils::MakeMaker)' (Makefile.PL:2). > FIX: Build-require `perl(Data::Dumper)' for running tests > (lib/Spreadsheet/XLSX.pm:13). > FIX: Build-require `perl(Exporter)' for running tests > (lib/Spreadsheet/XLSX/Utility2007.pm:12). > FIX: Build-require `perl(Test::More)' for running tests > (t/2_____with_chart.t:1). +BuildRequires: perl(ExtUtils::MakeMaker), perl(Data::Dumper), perl(Exporter) +BuildRequires: perl(Test::More) Ok. > TODO: You can use plain `perl' instead of macro `%{__perl}'. -%{__perl} Makefile.PL INSTALLDIRS=vendor +perl Makefile.PL INSTALLDIRS=vendor Ok. > TODO: You can replace `PERL_INSTALL_ROOT' with `DESTDIR' argument in > %install section. -make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +make pure_install DESTDIR=$RPM_BUILD_ROOT Ok. > TODO: You can remove explicit %defattr definition in %files sectinos. -%defattr(-,root,root,-) Ok. $ rpmlint perl-Spreadsheet-XLSX.spec ../SRPMS/perl-Spreadsheet-XLSX-0.13-2.fc20.src.rpm ../RPMS/noarch/perl-Spreadsheet-XLSX-0.13-2.fc20.noarch.rpm perl-Spreadsheet-XLSX.src: W: spelling-error %description -l en_US ParseExcel -> Parse Excel, Parse-excel, Paracelsus perl-Spreadsheet-XLSX.src: W: spelling-error %description -l en_US interoperability -> interchangeability, invulnerability, inseparability perl-Spreadsheet-XLSX.noarch: W: spelling-error %description -l en_US ParseExcel -> Parse Excel, Parse-excel, Paracelsus perl-Spreadsheet-XLSX.noarch: W: spelling-error %description -l en_US interoperability -> interchangeability, invulnerability, inseparability 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. > FIX: Declare all the build-time dependencies. Package builds in F20 (perl-Spreadsheet-XLSX-0.13-2.fc20.src.rpm). Ok. Package is good. Resolution: Package APPROVED.
Petr, thank you for the package review! New Package SCM Request ======================= Package Name: perl-Spreadsheet-XLSX Short Description: Perl extension for reading Microsoft Excel 2007 files Owners: robert Branches: el5 el6 f17 f18 f19 InitialCC:
Git done (by process-git-requests).
perl-Spreadsheet-XLSX-0.13-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Spreadsheet-XLSX-0.13-3.fc19
perl-Spreadsheet-XLSX-0.13-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Spreadsheet-XLSX-0.13-3.fc18
perl-Spreadsheet-XLSX-0.13-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Spreadsheet-XLSX-0.13-3.fc17
perl-Spreadsheet-XLSX-0.13-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Spreadsheet-XLSX-0.13-3.el6
perl-Spreadsheet-XLSX-0.13-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Spreadsheet-XLSX-0.13-3.el5
perl-Spreadsheet-XLSX-0.13-3.fc19 has been pushed to the Fedora 19 testing repository.
perl-Spreadsheet-XLSX-0.13-3.el5 has been pushed to the Fedora EPEL 5 stable repository.
perl-Spreadsheet-XLSX-0.13-3.el6 has been pushed to the Fedora EPEL 6 stable repository.
perl-Spreadsheet-XLSX-0.13-3.fc18 has been pushed to the Fedora 18 stable repository.
perl-Spreadsheet-XLSX-0.13-3.fc19 has been pushed to the Fedora 19 stable repository.
perl-Spreadsheet-XLSX-0.13-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Spreadsheet-XLSX-0.13-3.el7
perl-Spreadsheet-XLSX-0.13-3.el7 has been pushed to the Fedora EPEL 7 stable repository.