Bug 955276 - groonga package should be built with PIE flags
Summary: groonga package should be built with PIE flags
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: groonga
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kentaro Hayashi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-22 17:08 UTC by Dhiru Kholia
Modified: 2014-03-25 03:44 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-03 02:44:17 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Dhiru Kholia 2013-04-22 17:08:35 UTC
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package is long running ...".

However, currently groonga is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

groonga-httpd-3.0.2-1.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py groonga-httpd-3.0.2-1.fc19.x86_64.rpm
groonga-httpd,groonga-httpd-3.0.2-1.fc19.x86_64.rpm,/usr/sbin/groonga-httpd,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip

Comment 1 Kentaro Hayashi 2013-04-24 01:04:44 UTC
Thank you for reporting.

The groonga project will release groonga 3.0.3 at the end of this month.

So, I'll fix at that time.

Comment 2 Fedora Update System 2013-05-01 14:18:39 UTC
groonga-3.0.3-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/FEDORA-2013-6706/groonga-3.0.3-1.fc19

Comment 3 Kentaro Hayashi 2013-05-02 05:15:49 UTC
This issue was fixed at 3.0.3 release version.

$ python ~/work/checksec/scanner.py groonga-3.0.3-1.fc19.x86_64.rpm 
Analyzing groonga-3.0.3-1.fc19.x86_64.rpm ...
groonga,groonga-3.0.3-1.fc19.x86_64.rpm,/usr/bin/groonga,NX=Enabled,CANARY=Enabled,RELRO=Enabled,PIE=Enabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
groonga,groonga-3.0.3-1.fc19.x86_64.rpm,/usr/bin/groonga-benchmark,NX=Enabled,CANARY=Enabled,RELRO=Enabled,PIE=Enabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
$ python ~/work/checksec/scanner.py groonga-httpd-3.0.3-1.fc19.x86_64.rpm 
Analyzing groonga-httpd-3.0.3-1.fc19.x86_64.rpm ...
groonga-httpd,groonga-httpd-3.0.3-1.fc19.x86_64.rpm,/usr/sbin/groonga-httpd,NX=Enabled,CANARY=Enabled,RELRO=Enabled,PIE=Enabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
[kenhys@fedora18-amd64 tmp]$

Comment 4 Fedora Update System 2013-05-03 02:44:19 UTC
groonga-3.0.3-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 5 Dhiru Kholia 2013-05-06 05:49:50 UTC
Fix confirmed. Thanks for using scanner.py :-)


Note You need to log in before you can comment on or make changes to this bug.