Bug 960055 - nfs: add-brick, rebalance when locks are held nfs-server crashes
Summary: nfs: add-brick, rebalance when locks are held nfs-server crashes
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: mainline
Hardware: x86_64
OS: Linux
high
high
Target Milestone: ---
Assignee: Nagaprasad Sathyanarayana
QA Contact:
URL:
Whiteboard:
: 966855 (view as bug list)
Depends On: 959204 966855
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-06 14:02 UTC by shishir gowda
Modified: 2016-02-18 00:19 UTC (History)
6 users (show)

Fixed In Version: glusterfs-3.4.3
Doc Type: Bug Fix
Doc Text:
Clone Of: 959204
Environment:
Last Closed: 2014-04-17 13:12:41 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Comment 1 Anand Avati 2013-05-06 14:04:24 UTC
REVIEW: http://review.gluster.org/4958 (cluster/dht: Do not open fd in migration check/complete for non fd ops) posted (#2) for review on master by Shishir Gowda (sgowda)

Comment 2 Anand Avati 2013-05-07 09:44:03 UTC
REVIEW: http://review.gluster.org/4958 (cluster/dht: Do not open fd in migration check/complete for non fd ops) posted (#3) for review on master by Shishir Gowda (sgowda)

Comment 3 shishir gowda 2013-05-24 06:48:15 UTC
*** Bug 966855 has been marked as a duplicate of this bug. ***

Comment 4 Anand Avati 2013-05-31 12:16:21 UTC
COMMIT: http://review.gluster.org/4958 committed in master by Vijay Bellur (vbellur) 
------
commit c9bf5e6d2897de488967f5d736a5b9898b3deb94
Author: shishir gowda <sgowda>
Date:   Mon May 6 19:18:21 2013 +0530

    cluster/dht: Do not open fd in migration check/complete for non fd ops
    
    if local->fd == NULL, then in dht_migration_check_complete, do not do
    open call. Let the layout get updated, and proceed with invoking the
    registered target_fn.
    
    if local->fd == NULL, do not call dht_rebalance_in_progress_check for
    truncate fop, but proceed with truncate2.
    
    Change-Id: Ia5a5d40bcea7bfb320ef7096af1e035b8847d4ff
    BUG: 960055
    Signed-off-by: shishir gowda <sgowda>
    Reviewed-on: http://review.gluster.org/4958
    Reviewed-by: Amar Tumballi <amarts>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 5 Anand Avati 2013-06-04 04:11:42 UTC
REVIEW: http://review.gluster.org/5139 (Fix crash in dht_migration_complete_check_task because of NULL fd) posted (#1) for review on release-3.4 by Emmanuel Dreyfus (manu)

Comment 6 Anand Avati 2013-06-08 21:59:00 UTC
COMMIT: http://review.gluster.org/5139 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit bb0bbfecd609fff1a3890775b3119a552aba0e18
Author: Emmanuel Dreyfus <manu>
Date:   Tue Jun 4 06:08:24 2013 +0200

    Fix crash in dht_migration_complete_check_task because of NULL fd
    
    This is a backport of Ia5a5d40bcea7bfb320ef7096af1e035b8847d4ff
    
    BUG: 960055
    Change-Id: Ibf3547a775d7ca2f3a097c880cdf38ffafb322da
    Signed-off-by: Emmanuel Dreyfus <manu>
    Reviewed-on: http://review.gluster.org/5139
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 9 Niels de Vos 2014-04-17 13:12:41 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.4.3, please reopen this bug report.

glusterfs-3.4.3 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should already be or become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

The fix for this bug likely to be included in all future GlusterFS releases i.e. release > 3.4.3. In the same line the recent release i.e. glusterfs-3.5.0 [3] likely to have the fix. You can verify this by reading the comments in this bug report and checking for comments mentioning "committed in release-3.5".

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/5978
[2] http://news.gmane.org/gmane.comp.file-systems.gluster.user
[3] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137


Note You need to log in before you can comment on or make changes to this bug.