Description of problem: Tried to remove a brick from 1 x 2 replicate volume when one of the brick in the replicate volume is offline , the remove brick operation failed. But the volume type got changed to distribute. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1.Create a 1 x 2 replicate volume. (2 storage nodes and 1 brick on each node) 2.create fuse mount. create files and directories from mount point. 3.Bring down brick2 offline. 4.Try to remove the online brick. Actual results: The remove brick operation fails when gluster remove-brick 'commit' is given. But the volume type got changed to "Distribute" Expected results: The volume type should not change when the remove brick operation itself has failed. Additional info: Reference:Bug 923135
REVIEW: http://review.gluster.org/4975 (glusterd: remove-brick: prevent removal from a replicate volume.) posted (#2) for review on master by Ravishankar N (ravishankar)
REVIEW: http://review.gluster.org/4975 (glusterd: remove-brick: prevent removal from a replicate volume.) posted (#3) for review on master by Ravishankar N (ravishankar)
COMMIT: http://review.gluster.org/4975 committed in master by Vijay Bellur (vbellur) ------ commit 0d415f7f8c08edc7b7af88567bb5ec4803defc94 Author: Ravishankar N <ravishankar> Date: Thu May 9 16:14:33 2013 +0000 glusterd: remove-brick: prevent removal from a replicate volume. Prevent the removal of brick(s) from a plain replicate volume and display the error message at the CLI. Change-Id: I8e182404564147329d8cd364b7c7931d19f14570 BUG: 961669 Signed-off-by: Ravishankar N <ravishankar> Reviewed-on: http://review.gluster.org/4975 Reviewed-by: Vijay Bellur <vbellur> Tested-by: Gluster Build System <jenkins.com>
REVIEW: http://review.gluster.org/5289 (glusterd: add conditional checks for remove-brick in a replicate volume) posted (#1) for review on master by Ravishankar N (ravishankar)
REVIEW: http://review.gluster.org/5364 (glusterd: add conditional checks for remove-brick in a dist-rep volume) posted (#1) for review on master by Ravishankar N (ravishankar)
REVIEW: http://review.gluster.org/5566 (glusterd: add check in remove-brick start variant) posted (#1) for review on master by Ravishankar N (ravishankar)
COMMIT: http://review.gluster.org/5566 committed in master by Anand Avati (avati) ------ commit 51c6fa7a354826744de98a1c5c747955ae65850c Author: Ravishankar N <ravishankar> Date: Fri Jul 19 14:23:32 2013 +0000 glusterd: add check in remove-brick start variant The 'start' variant of the remove-brick command only applies at the dht level wherein we can remove all the bricks of a sub-volume (and remove multiple such sub-volumes) but not select bricks of it. This patch disallows removing individual replica bricks of multiple sub-volumes (i.e. reducing the replcia count of the volume) using remove-brick 'start'. The preferred method for such an operation is to use commit force. This patch also reverts the check to prevent removal of bricks from a replicate volume (commit 0d415f7) BUG: 961669 Change-Id: I447ad27f73a0963b5e09fb317bf7267a7a5a6147 Signed-off-by: Ravishankar N <ravishankar> Reviewed-on: http://review.gluster.org/5566 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Amar Tumballi <amarts> Reviewed-by: Anand Avati <avati>
REVIEW: http://review.gluster.org/6001 (glusterd: refactoring patch for Bug ID: 961669) posted (#1) for review on master by susant palai (spalai)
REVIEW: http://review.gluster.org/6001 (glusterd: refactoring patch for Bug ID: 961669) posted (#2) for review on master by susant palai (spalai)
REVIEW: http://review.gluster.org/6001 (glusterd: refactoring patch for Bug ID: 961669) posted (#3) for review on master by susant palai (spalai)
*** Bug 957005 has been marked as a duplicate of this bug. ***