Spec URL: http://averi.fedorapeople.org/RPMs/kgb-bot/kgb-bot.spec SRPM URL: http://averi.fedorapeople.org/RPMs/kgb-bot/kgb-bot-1.26-1.fc18.src.rpm Description: KGB is an IRC bot, helping people work together by notifying an IRC channel when a commit occurs. It supports multiple repositories/IRC channels and is fully configurable. Fedora Account System Username: averi For building this package you actually need perl-File-Touch and perl-Schedule-RateLimiter which are both on the fedora-testing-updates repository. You can enable them by tweaking your /etc/mock/fedora-18-x86_64 configuration file.
The rpmlint error: "kgb-bot.noarch: E: non-readable /etc/kgb-bot/kgb.conf 0640" is expected, the kgb-bot daemon wants its conf file to be non-world-readable.
I don't see the license file in the source package...Could the upstream provide it?
I'll poke them for doing so, for now we can just include a copy of the GPLv2 as SOURCE3 and have it installed on the package and on the subpackages.
The license file can't be provide as SOURCE3, it should be include by the upstream. Could you use the macro (es. %{name}) when it is possible in the spec file? Then the rpm package should be ok to be approve.
Ah, correct, that's actually true. I'll poke upstream to have it included for the next upstream release. I've moved the 'kgb-bot' entries into %{name} as requested. The URL is the same.
I am waiting new package with the license provide by upstream. Then I will do an official review! Thank you!
OK, upstream has included a LICENSE file, added that. We should be good to go now. Same URL as before.
Could you fix name of package following the naming guidelines for snapshots package? http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages Thank you!
Indeed, that's done: Spec: http://averi.fedorapeople.org/RPMs/kgb-bot/kgb-bot.spec SRPM: http://averi.fedorapeople.org/RPMs/kgb-bot/kgb-bot-1.26-12052013svn880.fc18.src.rpm
Even better: year-month-day, SRPM: kgb-bot-1.26-20130512svn880.fc18.src.rpm SPEC at the same URL.
kgb-client subpackage doesn't exist. On line 82 of your spec file you have: Requires: kgb-client Maybe you want to use kgb-bot-client, that exist.
Fixed, same URL. Spec: http://averi.fedorapeople.org/RPMs/kgb-bot/kgb-bot.spec SRPMS: http://averi.fedorapeople.org/RPMs/kgb-bot/kgb-bot-1.26-20130512svn880.fc18.src.rpm
Created attachment 747239 [details] review created using fedora-review tool For me the package is APPROVED. Just fix this before to submit it: [!]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kgb-bot- client , kgb-bot-client-git On line 82 of spec file write: Requires: %{name}-client = %{version}-%{release} In attachment my review.txt created with the help of fedora-review tool.
New Package SCM Request ======================= Package Name: kgb-bot Short Description: IRC Collaboration Bot Owners: averi Branches: f18 f19
Git done (by process-git-requests).
kgb-bot-1.26-20130512svn880.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/kgb-bot-1.26-20130512svn880.fc19
kgb-bot-1.26-20130512svn880.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kgb-bot-1.26-20130512svn880.fc18
kgb-bot-1.26-20130512svn880.fc19 has been pushed to the Fedora 19 testing repository.
kgb-bot-1.26-20130516svn880.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kgb-bot-1.26-20130516svn880.fc18
kgb-bot-1.26-20130516svn880.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/kgb-bot-1.26-20130516svn880.fc19
kgb-bot-1.26-20130523svn880.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/kgb-bot-1.26-20130523svn880.fc19
kgb-bot-1.26-20130523svn880.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kgb-bot-1.26-20130523svn880.fc18
kgb-bot-1.26-20130523svn880.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
kgb-bot-1.26-20130523svn880.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
The package is in Fedora, I believe this should be closed.