Red Hat Bugzilla – Bug 962496
kernel: powerpc: can't enable MSIs for AMD FirePro 2270 adapter
Last modified: 2013-06-14 08:54:39 EDT
Created attachment 747296 [details]
PATCH: powerpc/pseries: Force 32 bit MSIs for devices that require it (e61133dda480062d221f09e4fc18f66763f8ecd0)
Description of problem:
The AMD FirePro 2270 graphics adapter reports to the OS that it supports 64-bit MSIs, however, it doesn't actually work if the platform really uses the whole 64 bits for addressing.
A change has been added to the PAPR document to allow the OS to force the use of 32-bit MSI in such cases even if the PCI capabilities of the adapter indicate otherwise.
A PCI quirk has been added to the ppc64/pseries code to enable the usage of this adapter on ppc64/pseries systems.
These changes have been introduced by commit e61133dda480062d221f09e4fc18f66763f8ecd0.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Load the radeon adapter on a ppc64/pseries system with an AMD FirePro 2270 adapter
Driver can't enable MSI on the adapter.
Adapter working with MSI enabled.
Can you please consider including this patch for F19?
Is there a reason this needs to go into F19 as opposed to rawhide, where I would expect it to be brought into the upstream 3.10-rcX tree relatively soon?
Hi Josh, is the 3.10 kernel going into F19 before the final release? If that is the case it works for us.
(In reply to comment #3)
> Hi Josh, is the 3.10 kernel going into F19 before the final release? If that
> is the case it works for us.
No, it isn't.
I'm unaware of why F19 is your target when you clearly have numerous items that aren't going to be in the GA kernel for F19. Perhaps you have some internal process or dates that didn't line up with the Fedora schedule, but 3.9 is going to be the GA kernel for F19. 3.10 will likely be a 0-day update (or very close to it.)
We will, however, be continuing to pull in the latest upstream 3.9.y stable kernels throughout the rest of the F19 schedule. As I suggested in another bug, you might want to look at getting this patch into 3.9.y as a stable fix. Then it would be picked up automatically, and everyone using that kernel will benefit, not just Fedora. We'd also have one less patch to carry.
Adam pointed this commit out to me again today (along with f1dd153121dcb872ae6cba8d52bec97519eb7d97). I see that nobody has tried to get it into the stable tree, which is unfortunate.
I'll look at picking these two fixes up for f19 soon. In the meantime, it is still best if you get them into 3.9.y stable.
kernel-3.9.4-301.fc19 has been submitted as an update for Fedora 19.
FYI, kernel-3.9.4-301.fc19 fails to build on Power.
Let me know if you want a separate bugzilla for this but I suspect it's related.
(In reply to David Aquilina from comment #7)
> FYI, kernel-3.9.4-301.fc19 fails to build on Power.
> Let me know if you want a separate bugzilla for this but I suspect it's
Irritating. commit e375b561817d9ae098cc4296a729fc88924a0159 introduced that, which is obviously missing in 3.9.y.
I believe I've fixed this now. The resulting kernel will need to be heavily tested. If it doesn't work, then someone will need to provide patches against 3.9.y that do.
Thank you for picking up the patch and very sorry for the problem it caused. I should have stated that the patch pointed by Adam wouldn't apply cleanly on top of 3.9.
I have tested your changes and it didn't introduce any problem, the radeon driver can initialize the card on systems where the hack is needed.
I will work on get this patch sent to 3.9.y stable tree.
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing kernel-3.9.4-301.fc19'
as soon as you are able to, then reboot.
Please go to the following url:
then log in and leave karma (feedback).
kernel-3.9.4-301.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
kernel-3.9.5-301.fc19 has been submitted as an update for Fedora 19.
kernel-3.9.5-301.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
Both patches have made it now to the stable 3.9.y tree and were released on 3.9.6.
powerpc/pseries: Force 32 bit MSIs for devices that require it
powerpc/pseries: Make 32-bit MSI quirk work on systems lacking firmware support