Bug 963292 - Review Request: perl-SOOT - Use ROOT from Perl
Summary: Review Request: perl-SOOT - Use ROOT from Perl
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 963136
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-15 15:09 UTC by Petr Pisar
Modified: 2013-05-29 11:41 UTC (History)
3 users (show)

Fixed In Version: perl-SOOT-0.17-1.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-29 11:41:16 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2013-05-15 15:09:45 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-SOOT/perl-SOOT.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-SOOT/perl-SOOT-0.17-1.fc20.src.rpm
Description:
SOOT is a Perl extension for using the ROOT library. It is very similar to the
Ruby-ROOT or PyROOT extensions for their respective languages. Specifically,
SOOT was implemented after the model of Ruby-ROOT.

Fedora Account System Username: ppisar

Comment 1 Petr Šabata 2013-05-27 15:28:08 UTC
Ok, looks good except for one missing BR: perl(constant), t/045tf1.t:3

Comment 2 Petr Pisar 2013-05-28 06:53:12 UTC
You are right. Updated package is at the same locator.

Comment 3 Petr Šabata 2013-05-28 09:10:20 UTC
--- a/perl-SOOT.spec
+++ b/perl-SOOT.spec
@@ -33,6 +33,7 @@ BuildRequires:  perl(File::Basename)
 BuildRequires:  perl(overload)
 BuildRequires:  perl(XSLoader)
 # Tests:
+BuildRequires:  perl(constant)
 BuildRequires:  perl(Test::More)
 Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 Requires:       perl(Carp) >= 1.01

--
Approving.

Comment 4 Petr Pisar 2013-05-28 09:14:48 UTC
New Package SCM Request
=======================
Package Name: perl-SOOT
Short Description: Use ROOT from Perl
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2013-05-28 15:39:41 UTC
Git done (by process-git-requests).

Comment 6 Petr Pisar 2013-05-29 11:41:16 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.