Red Hat Bugzilla – Bug 963537
Fix misleading log messages of the form "Node <N> responded to <N>"
Last modified: 2013-07-24 13:24:50 EDT
+++ This bug was initially created as a clone of Bug #963534 +++
Description of problem:
glusterd logs (wrongly) indicate that a node responded to itself, although it actually responded to one of its peers, in the function glusterd_xfer_friend_add_resp().
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Have a cluster of two nodes N1 and N2,
2. Restart glusterd on both of them after ensuring they are both connected to each other.
3. Check the glusterd logs.
N1's glusterd logs say "Responded to N1" when it responded to N2, and vice versa, thereby rendering the logs extremely misleading while debugging issues of the kind https://bugzilla.redhat.com/show_bug.cgi?id=962266 and https://bugzilla.redhat.com/show_bug.cgi?id=961703.
In step 3, N1's glusterd logs must say "Responded to N2" when it responds to N2 and vice versa.
REVIEW: http://review.gluster.org/5017 (glusterd: Fix misleading log messages of the kind "Node <n> responded to <n>") posted (#1) for review on master by Krutika Dhananjay (email@example.com)
COMMIT: http://review.gluster.org/5017 committed in master by Vijay Bellur (firstname.lastname@example.org)
Author: Krutika Dhananjay <email@example.com>
Date: Thu May 16 10:43:54 2013 +0530
glusterd: Fix misleading log messages of the kind "Node <n> responded to <n>"
glusterd logs coming from glusterd_xfer_friend_add_resp() (wrongly)
indicate that a node responded to itself, although it actually
responded to one of its peers.
Make glusterd_xfer_friend_add_resp() distinguish between remote host
and self and print the appropriate hostname.
Signed-off-by: Krutika Dhananjay <firstname.lastname@example.org>
Reviewed-by: Amar Tumballi <email@example.com>
Reviewed-by: Krishnan Parthasarathi <firstname.lastname@example.org>
Tested-by: Gluster Build System <email@example.com>