Bug 963537 - Fix misleading log messages of the form "Node <N> responded to <N>"
Fix misleading log messages of the form "Node <N> responded to <N>"
Status: CLOSED CURRENTRELEASE
Product: GlusterFS
Classification: Community
Component: glusterd (Show other bugs)
mainline
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Krutika Dhananjay
:
Depends On: 963534
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-16 01:52 EDT by Krutika Dhananjay
Modified: 2013-07-24 13:24 EDT (History)
3 users (show)

See Also:
Fixed In Version: glusterfs-3.4.0
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 963534
Environment:
Last Closed: 2013-07-24 13:24:50 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Krutika Dhananjay 2013-05-16 01:52:38 EDT
+++ This bug was initially created as a clone of Bug #963534 +++

Description of problem:

glusterd logs (wrongly) indicate that a node responded to itself, although it actually responded to one of its peers, in the function glusterd_xfer_friend_add_resp().

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Have a cluster of two nodes N1 and N2,
2. Restart glusterd on both of them after ensuring they are both connected to each other.
3. Check the glusterd logs. 
  
Actual results:
N1's glusterd logs say "Responded to N1" when it responded to N2, and vice versa, thereby rendering the logs extremely misleading while debugging issues of the kind https://bugzilla.redhat.com/show_bug.cgi?id=962266 and https://bugzilla.redhat.com/show_bug.cgi?id=961703.

Expected results:
In step 3, N1's glusterd logs must say "Responded to N2" when it responds to N2 and vice versa.

Additional info:
Comment 1 Anand Avati 2013-05-16 03:05:03 EDT
REVIEW: http://review.gluster.org/5017 (glusterd: Fix misleading log messages of the kind "Node <n> responded to <n>") posted (#1) for review on master by Krutika Dhananjay (kdhananj@redhat.com)
Comment 2 Anand Avati 2013-05-16 11:31:55 EDT
COMMIT: http://review.gluster.org/5017 committed in master by Vijay Bellur (vbellur@redhat.com) 
------
commit db18b17c88c1976f9e523c4c6712c7e444927cc4
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date:   Thu May 16 10:43:54 2013 +0530

    glusterd: Fix misleading log messages of the kind "Node <n> responded to <n>"
    
    PROBLEM:
    
    glusterd logs coming from glusterd_xfer_friend_add_resp() (wrongly)
    indicate that a node responded to itself, although it actually
    responded to one of its peers.
    
    FIX:
    
    Make glusterd_xfer_friend_add_resp() distinguish between remote host
    and self and print the appropriate hostname.
    
    Change-Id: I2a504eeb058c08a0d378443888eb6f1dc7edc76f
    BUG: 963537
    Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
    Reviewed-on: http://review.gluster.org/5017
    Reviewed-by: Amar Tumballi <amarts@redhat.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
    Tested-by: Gluster Build System <jenkins@build.gluster.com>

Note You need to log in before you can comment on or make changes to this bug.