Description of problem:
If trying to add SSL for an alias with empty file, no error would be returned.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1.Log to openshift web console with a user with SSL Certificates Supported permission.
2.Add an alias to an app.
3.Add an empty key file for SSL and certificate private key field.
"Alias has been updated" is shown.
Error message "Invalid certificate file" is shown.
It works well from rhc client as below:
# rhc alias update-cert eap11 foo3.bar.com --certificate empty.crt --private-key empty.key -l email@example.com
Invalid certificate file: empty.crt is empty
The broker should be returning an error in this case, not the clients.
The code on broker was recently changed to accommodate for cases where the console sends an empty string for params that are not specified by user. So the broker now treats empty strings as nil.
Since, the SSL parameters are optional for alias creation and the values are empty (nil) then the alias is created without a certificate and no error is thrown.
We can change the broker back to throwing errors when the values for the following parameters is an empty string. But the console then should not send empty strings for nil or not specified values.
Going to spend time re-writing this area of the code.
Commit pushed to master at https://github.com/openshift/origin-server
Bug 971337 - cleanup alias form errors
Add alias views for new and edit
Get existing aliases test cases working with new routing and templates
Add new test cases to cover SSL cert errors for empty or missing files
Grammar corrections for ssl cert messages
Show form errors on alias edit
Add test case for errors on alias edit form
Testcase for create alias with a cert
Rename PersistentConnectionError to ResetConnectionError
Verified on devenv_3149
After adding SSL for an alias with empty file,it returns "SSL certificate file was empty."