Red Hat Bugzilla – Bug 971807
Better rsyslog support
Last modified: 2015-03-03 18:06:50 EST
I'm going to publish series of enhancement patches, bringing better support for rsyslog within the provider.
Created attachment 758102 [details]
Use internal memory array for Syslog_MessageLog values
This first patch is a basis for future enhancements. It parses all items for Syslog_MessageLog during Syslog_MessageLog_Begin_Enum() and stores the data in memory, contrary to using a temporary file. The temporary file approach is retained for the Syslog_LogRecord case where large amounts of data are not convenient to be stored in memory.
Created attachment 758114 [details]
Parse rsyslog includes
This second patch adds support for $IncludeConfig directives within the rsyslog.conf configuration file. This means adding proper support for separate config files in /etc/rsyslog.d/ directory, as we have in Fedora.
Created attachment 759163 [details]
Parse rsyslog includes for Syslog_Setting instances
First of series of patches to properly support rsysglog $IncludeConfig directive in Syslog_Setting classes.
Created attachment 760056 [details]
Add support for filter definitions
This to support filter-type rules such as
:msg, contains, "error" /var/log/error.log
Created attachment 760234 [details]
Don't crash when calling a method with zero arguments
Simple crasher fix
Created attachment 762019 [details]
Handle missing ConfInFile file gracefully
Small fix for a crasher found by having empty /etc/rsyslog.conf file.
Created attachment 762020 [details]
Handle cross-filesystem rename
This patch fixes the case of having temporary file on different filesystem than the target file, e.g. creating new Syslog_Setting instance resulting in writing new rules through a temporary file.
Created attachment 763500 [details]
Proper write support for rsyslog includes in Syslog_Setting
This patch fixes and enhances rule write support through Syslog_Setting instances. It's a bit large due to number of changes needed to be done.
The only thing I'm aware is broken (and was before) is removing a rule from multiple rule line. Removing single rules works fine. This is going to be addressed in the next patch.
Created attachment 764673 [details]
Fix Syslog_Setting instance deletion
This patch fixes instance deletion and brings more robustness wrt to rule string matching.
Created attachment 765149 [details]
Handle unset properties on method calls better
(In reply to Tomáš Bžatek from comment #5)
> Created attachment 760234 [details]
> Don't crash when calling a method with zero arguments
> Simple crasher fix
The attached patch is a follow up on this one, further extending it.
Created attachment 765151 [details]
Fix some compiler warnings
Patch to fix some compiler warnings related to the patches I posted.
Filed upstream bugreport https://sourceforge.net/p/sblim/bugs/2645/
Created attachment 765626 [details]
Allow Syslog_Setting.Priority key to be empty string
One more patch to fix a problem with filter rules.
Created attachment 767429 [details]
Handle cross-filesystem rename
An updated patch fixing some compilation issues.
sblim-cmpi-syslog-0.8.0-10.20120315cvs.fc19 has been submitted as an update for Fedora 19.
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing sblim-cmpi-syslog-0.8.0-10.20120315cvs.fc19'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
sblim-cmpi-syslog-0.8.0-10.20120315cvs.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.