Bug 972456 - [TEXT] Missing description, during detach VM from vm pool action
[TEXT] Missing description, during detach VM from vm pool action
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine (Show other bugs)
x86_64 Linux
unspecified Severity medium
: ---
: 3.3.0
Assigned To: Frantisek Kobzik
: Triaged
Depends On:
  Show dependency treegraph
Reported: 2013-06-09 10:54 EDT by vvyazmin@redhat.com
Modified: 2015-09-22 09 EDT (History)
10 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2013-07-16 08:27:50 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
## Logs rhevm (800.93 KB, application/x-gzip)
2013-06-09 10:54 EDT, vvyazmin@redhat.com
no flags Details

External Trackers
Tracker ID Priority Status Summary Last Updated
oVirt gerrit 16910 None None None Never

  None (edit)
Description vvyazmin@redhat.com 2013-06-09 10:54:11 EDT
Created attachment 758820 [details]
## Logs rhevm

Description of problem: Missing description, during detach VM from vm pool action

Version-Release number of selected component (if applicable):
RHEVM 3.2 - SF17.1 environment: 

RHEVM: rhevm-3.2.0-11.28.el6ev.noarch 
VDSM: vdsm-4.10.2-21.0.el6ev.x86_64 
LIBVIRT: libvirt-0.10.2-18.el6_4.5.x86_64 
QEMU & KVM: qemu-kvm-rhev- 
SANLOCK: sanlock-2.6-2.el6.x86_64

How reproducible:

Steps to Reproduce:
1. Crete VM pool
2. Via PythonSDK detach VM from VM pool with wrong name or detach VM from pool that is not in  relevant pool. 
Actual results:
Get an error with missing description.  
Via log, impossible to know, on which VM name I failed

Expected results:
In log get VM name

Impact on user:


Additional info:

2013-06-06 10:59:15,956 WARN  [org.ovirt.engine.core.bll.RemoveVmFromPoolCommand] (ajp-/ [5e7a57f7] CanDoAction of action RemoveVmFromPool failed. Reasons:VM_POOL_CANNOT_DETACH
2013-06-06 10:59:15,957 ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (ajp-/ Operation Failed: [Cannot detach VM from pool. VM is not attached to the VM

Comment 1 Omer Frenkel 2013-07-16 05:52:40 EDT
this is how the system works,
if you do some action on object X, and the action can't be executed, you know the object is X.
some examples:
try to remove up vm: "Cannot remove VM. VM is running."
try to remove up host: "Cannot remove Host. Host is operational. Please switch Host to Maintenance mode first."
and so on, not only for remove flows, any action in the system that fails the can-do-action phase will not mention the object name, it is known to the user..

it might worth adding some infrastucture to log also the object name/id that is related to the command, not for this command only.
Comment 2 Frantisek Kobzik 2013-07-16 06:20:46 EDT
I definitely agree that it calls for more general solution, but this is out of scope of this bug. I did it this way, because I'm seeing this approach in more backend commands. 

So what do you suggest, Omer? To abandon seggested mini-patch and think about something more general?
Comment 3 Frantisek Kobzik 2013-07-16 08:27:50 EDT
The solution of this bug requires more general approach that affects all commands (as briefly suggested in the comment 1). Therefore a new bug should be filed that covers this.

Note You need to log in before you can comment on or make changes to this bug.