Description of problem: While looking at the newly introduced procedures FALLOCATE and DISCARD, it seems that these were added with already existing procedure numbers. This makes the protocol incompatible with existing roll-outs. Version-Release number of selected component (if applicable): $ git log --oneline -1 d1ccc4e4 d1ccc4e gluster: add fallocate fop support $ git describe --tags d1ccc4e4 v3.4.0alpha-343-gd1ccc4e $ git log --oneline -1 17f28717 17f2871 glusterfs: discard (hole punch) support $ git describe --tags 17f28717 v3.4.0alpha-344-g17f2871 Additional info: It is very confusing when new procedures are added somewhere in the middle of the array. This will cause the number of existing procedures to change. It is much preferred to add new procedures at the end of the array. This greatly simplifies adding support for these new procedures in Wireshark and will prevent confusion to the people reading network traces (with or without Wireshark).
REVIEW: http://review.gluster.org/5215 (protocol/rpc: move latest added procedures to the end of the array) posted (#2) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/5228 (protocol/rpc: move latest added procedures to the end of the array) posted (#1) for review on release-3.4 by Niels de Vos (ndevos)
COMMIT: http://review.gluster.org/5215 committed in master by Anand Avati (avati) ------ commit eb6b81e1fc182daba4d202d15362250eee1c86d6 Author: Niels de Vos <ndevos> Date: Mon Jun 17 10:56:55 2013 +0200 protocol/rpc: move latest added procedures to the end of the array While looking at the newly introduced procedures FALLOCATE and DISCARD, it seems that these were added with already existing procedure numbers. This makes the protocol incompatible with existing roll-outs. It is very confusing when new procedures are added somewhere in the middle of the array. This will cause the number of existing procedures to change. It is much preferred to add new procedures at the end of the array. This changes not only corrects the enum that generates the procedure numbers, but also the ordering in the client and server fops-array for clarity. Correcting this greatly simplifies adding support for these new procedures in Wireshark and will prevent confusion to the people reading network traces (with or without Wireshark). Change-Id: Ib9e7978531d016c7230d756b855cb94cb0793b0f BUG: 974976 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/5215 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Brian Foster <bfoster> Reviewed-by: Anand Avati <avati>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report. glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user