Description of problem: Given an app of DIY type, the comment of its start hook still refers to OPENSHIFT_INTERNAL_IP which is out-of-date, but the actual code invokes OPENSHIFT_DIY_IP, and this inconsistency could cause unnecessary confusion. Version-Release number of selected component (if applicable): INT(devenv_3395) How reproducible: always Steps to Reproduce: 1. create a DIY app 2. review the content of its start hook vim .openshift/action_hooks/start Actual results: The comment refers to OPENSHIFT_INTERNAL_IP: # The logic to start up your application should be put in this # script. The application will work only if it binds to # $OPENSHIFT_INTERNAL_IP:8080 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ But the actual code invokes OPENSHIFT_DIY_IP: nohup $OPENSHIFT_REPO_DIR/diy/testrubyserver.rb $OPENSHIFT_DIY_IP ^^^^^^^^^^^^^^^^^ $OPENSHIFT_REPO_DIR/diy > $OPENSHIFT_DIY_DIR/logs/server.log 2>&1 & Expected results: The comment should refer to the latest env vars. Additional info:
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/50e5cf51d46f9ed67aa08e0e906d2497bad7fe5d Bug 976758 & 969948 - Update the name of internal IP env var to match v2 carts https://bugzilla.redhat.com/show_bug.cgi?id=976758 https://bugzilla.redhat.com/show_bug.cgi?id=969948 Changed the OPENSHIFT_INTERNAL_IP env var in index.html and start hook to OPENSHIFT_DIY_IP
Verified in devenv_3414 Steps are the same in Description, and the comments in the start hook are: # The logic to start up your application should be put in this # script. The application will work only if it binds to # $OPENSHIFT_DIY_IP:8080