Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 977843

Summary: Get proper error when sending non-existing network in setupNetworks
Product: Red Hat Enterprise Virtualization Manager Reporter: Meni Yakove <myakove>
Component: vdsmAssignee: Antoni Segura Puimedon <asegurap>
Status: CLOSED ERRATA QA Contact: Meni Yakove <myakove>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.3.0CC: acathrow, asegurap, bazulay, danken, iheim, jkt, lpeer, yeylon
Target Milestone: ---   
Target Release: 3.3.0   
Hardware: x86_64   
OS: All   
Whiteboard: network
Fixed In Version: is7 Doc Type: Bug Fix
Doc Text:
When processing a non-existing network, VDSM assumed that it was for creation and unexpectedly fail when it could not find the network definition. Now VDSM checks if the non-existing network is marked for removal. As a result, trying to remove a non-existing network will properly notify users that the network is missing.
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-21 16:09:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1019461    
Attachments:
Description Flags
vdsm.log
none
engine.log none

Description Meni Yakove 2013-06-25 13:01:38 UTC
Created attachment 765074 [details]
vdsm.log

Description of problem:
When sending setupNetworks with non-existing network we get Traceback instead of proper error about network is not exist.

Version-Release number of selected component (if applicable):
vdsm-4.11.0-35.git34c1ef1.el6.x86_64
rhevm-3.3.0-0.4.master.el6ev.noarch


Actual results:
Get Traceback in logs

Expected results:
Get proper error in log

Additional info:
VDSM:
Thread-43799::DEBUG::2013-06-25 14:47:32,977::BindingXMLRPC::926::vds::(wrapper) client [10.35.161.40]::call setupNetworks with ({'sw59': {'remove': 'true'}, 'sw58': {'remove': 'true'}, 'sw51
': {'remove': 'true'}, 'sw50': {'remove': 'true'}, 'sw53': {'remove': 'true'}, 'sw52': {'remove': 'true'}, 'sw55': {'remove': 'true'}, 'sw54': {'remove': 'true'}, 'sw57': {'remove': 'true'}, 
'sw56': {'remove': 'true'}, 'sw28': {'remove': 'true'}, 'sw29': {'remove': 'true'}, 'sw24': {'remove': 'true'}, 'sw25': {'remove': 'true'}, 'sw26': {'remove': 'true'}, 'sw27': {'remove': 'tru
e'}, 'sw20': {'remove': 'true'}, 'sw21': {'remove': 'true'}, 'sw22': {'remove': 'true'}, 'sw23': {'remove': 'true'}, 'sw39': {'remove': 'true'}, 'sw38': {'remove': 'true'}, 'sw37': {'remove':
 'true'}, 'sw36': {'remove': 'true'}, 'sw35': {'remove': 'true'}, 'sw34': {'remove': 'true'}, 'sw33': {'remove': 'true'}, 'sw32': {'remove': 'true'}, 'sw31': {'remove': 'true'}, 'sw30': {'rem
ove': 'true'}, 'sw82': {'remove': 'true'}, 'sw83': {'remove': 'true'}, 'sw80': {'remove': 'true'}, 'sw81': {'remove': 'true'}, 'sw86': {'remove': 'true'}, 'sw87': {'remove': 'true'}, 'sw84': 
{'remove': 'true'}, 'sw85': {'remove': 'true'}, 'sw88': {'remove': 'true'}, 'sw89': {'remove': 'true'}, 'sw15': {'remove': 'true'}, 'sw14': {'remove': 'true'}, 'sw17': {'remove': 'true'}, 'sw
16': {'remove': 'true'}, 'sw11': {'remove': 'true'}, 'sw10': {'remove': 'true'}, 'sw13': {'remove': 'true'}, 'sw12': {'remove': 'true'}, 'sw19': {'remove': 'true'}, 'sw18': {'remove': 'true'}
, 'sw99': {'remove': 'true'}, 'sw98': {'remove': 'true'}, 'sw95': {'remove': 'true'}, 'sw94': {'remove': 'true'}, 'sw97': {'remove': 'true'}, 'sw96': {'remove': 'true'}, 'sw91': {'remove': 't
rue'}, 'sw90': {'remove': 'true'}, 'sw93': {'remove': 'true'}, 'sw92': {'remove': 'true'}, 'sw60': {'remove': 'true'}, 'sw61': {'remove': 'true'}, 'sw62': {'remove': 'true'}, 'sw63': {'remove
': 'true'}, 'sw64': {'remove': 'true'}, 'sw65': {'remove': 'true'}, 'sw66': {'remove': 'true'}, 'sw67': {'remove': 'true'}, 'sw68': {'remove': 'true'}, 'sw69': {'remove': 'true'}, 'sw9': {'re
move': 'true'}, 'sw8': {'remove': 'true'}, 'sw1': {'remove': 'true'}, 'sw3': {'remove': 'true'}, 'sw2': {'remove': 'true'}, 'sw5': {'remove': 'true'}, 'sw4': {'remove': 'true'}, 'sw7': {'remo
ve': 'true'}, 'sw6': {'remove': 'true'}, 'sw73': {'remove': 'true'}, 'sw72': {'remove': 'true'}, 'sw71': {'remove': 'true'}, 'sw70': {'remove': 'true'}, 'sw77': {'remove': 'true'}, 'sw76': {'
remove': 'true'}, 'sw75': {'remove': 'true'}, 'sw74': {'remove': 'true'}, 'sw79': {'remove': 'true'}, 'sw78': {'remove': 'true'}, 'sw48': {'remove': 'true'}, 'sw49': {'remove': 'true'}, 'sw46
': {'remove': 'true'}, 'sw47': {'remove': 'true'}, 'sw44': {'remove': 'true'}, 'sw45': {'remove': 'true'}, 'sw42': {'remove': 'true'}, 'sw43': {'remove': 'true'}, 'sw40': {'remove': 'true'}, 
'sw41': {'remove': 'true'}}, {}, {'connectivityCheck': 'true', 'connectivityTimeout': 60}) {} flowID [23b7da6e]
Thread-43800::DEBUG::2013-06-25 14:47:32,980::BindingXMLRPC::926::vds::(wrapper) client [10.35.161.40]::call ping with () {} flowID [23b7da6e]
Thread-43800::DEBUG::2013-06-25 14:47:32,980::BindingXMLRPC::933::vds::(wrapper) return ping with {'status': {'message': 'Done', 'code': 0}}
Thread-43799::ERROR::2013-06-25 14:47:33,063::BindingXMLRPC::945::vds::(wrapper) unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/BindingXMLRPC.py", line 931, in wrapper
    res = f(*args, **kwargs)
  File "/usr/share/vdsm/BindingXMLRPC.py", line 380, in setupNetworks
    return api.setupNetworks(networks, bondings, options)
  File "/usr/share/vdsm/API.py", line 1228, in setupNetworks
    supervdsm.getProxy().setupNetworks(networks, bondings, options)
  File "/usr/share/vdsm/supervdsm.py", line 49, in __call__
    return callMethod()
  File "/usr/share/vdsm/supervdsm.py", line 48, in <lambda>
    **kwargs)
  File "<string>", line 2, in setupNetworks
  File "/usr/lib64/python2.6/multiprocessing/managers.py", line 740, in _callmethod
    raise convert_to_error(kind, result)
KeyError: 'nic'

ENGINE:
2013-06-25 15:21:26,382 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.SetupNetworksVDSCommand] (ajp-/127.0.0.1:8702-8) [5b047f51] Error code unexpected and error message VDSGenericExceptio
n: VDSErrorException: Failed to SetupNetworksVDS, error = Unexpected exception

Comment 1 Meni Yakove 2013-06-25 13:04:56 UTC
Created attachment 765076 [details]
engine.log

Comment 2 Meni Yakove 2013-07-28 17:37:59 UTC
vdsm-4.12.0-rc3.12.git139ec2f.el6ev.x86_64
rhevm-3.3.0-0.11.master.el6ev.noarch

Comment 3 Charlie 2013-11-28 00:34:50 UTC
This bug is currently attached to errata RHBA-2013:15291. If this change is not to be documented in the text for this errata please either remove it from the errata, set the requires_doc_text flag to 
minus (-), or leave a "Doc Text" value of "--no tech note required" if you do not have permission to alter the flag.

Otherwise to aid in the development of relevant and accurate release documentation, please fill out the "Doc Text" field above with these four (4) pieces of information:

* Cause: What actions or circumstances cause this bug to present.
* Consequence: What happens when the bug presents.
* Fix: What was done to fix the bug.
* Result: What now happens when the actions or circumstances above occur. (NB: this is not the same as 'the bug doesn't present anymore')

Once filled out, please set the "Doc Type" field to the appropriate value for the type of change made and submit your edits to the bug.

For further details on the Cause, Consequence, Fix, Result format please refer to:

https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes 

Thanks in advance.

Comment 4 errata-xmlrpc 2014-01-21 16:09:29 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0040.html