Bug 978255 - autopart (use free space) install does not report that existing partitions will remain untouched
Summary: autopart (use free space) install does not report that existing partitions wi...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-06-26 08:13 UTC by Peter Kotvan
Modified: 2013-08-02 11:08 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-06-27 00:44:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screenshot showing INSTALLATION OPTIONS dialog described in Comment 4 (71.50 KB, image/png)
2013-08-01 11:51 UTC, Steve Tyler
no flags Details
screenshot showing SUMMARY OF CHANGES dialog after completing Manual Partitioning (85.54 KB, image/png)
2013-08-01 12:02 UTC, Steve Tyler
no flags Details

Description Peter Kotvan 2013-06-26 08:13:12 UTC
Description of problem:
When installing f19 on system with existing partitions and enough free space, option for automatic configuration does not inform that existing partitions and file systems will be preserved during the installation.

Version-Release number of selected component (if applicable):
f19rc2, anaconda-19.30.12-1

How reproducible:
Do automatic install of f19 on system with existing partitions (or existing system installed).

Steps to Reproduce:
1. Have a machine with existing partitions or installed system. Ensure that there is enough free space on discs for new fedora installation.
2. During the installation of new system select automatic installation using free space.

Actual results:
Anaconda does not inform user that existing partitions will not be modified or deleted during the installation

Expected results:
Anaconda should state that existing partitions will remain untouched after installation of f19.

Comment 1 Brian Lane 2013-06-27 00:44:40 UTC
Well, that's what 'use free space' means.

Comment 2 Steve Tyler 2013-08-01 05:02:49 UTC
Sheesh, Peter was just asking for a more detailed report of what the installer is going to do when autopart is selected. How hard is that to understand?

Comment 3 Steve Tyler 2013-08-01 05:14:29 UTC
Peter: Where in the GUI would you propose that information be presented?

Comment 4 Peter Kotvan 2013-08-01 07:07:18 UTC
I tried this once again in a virtual machine. After i selected the disc with existing partitions i got this exactly:

INSTALLATION OPTIONS

You have ....GB of free space, which is enough to install Fedora. What would you like to do?

* Automatically configure my Fedora installation to disk(s) I selected and return me to the main menu.

Then follow other options that are not important in this case.

When I see "Automatically configure" it makes me little suspicious because I'm going to let installer mess with my disks/partitions. So I think that installer should explicitly say that existing partitions will remain as they are. I would expect something like this:

* Automatically configure my Fedora installation to disk(s) I selected and return me to the main menu. Existing partitions will be preserved.

Comment 5 Steve Tyler 2013-08-01 11:51:29 UTC
Created attachment 781541 [details]
screenshot showing INSTALLATION OPTIONS dialog described in Comment 4

Thanks for your comments. I understand your suspicions ... :-)

Since you are testing in a VM, you can easily take screenshots and attach them to this bug. This attachment shows the dialog you are referring to.

The additional wording sounds good to me:
"Existing partitions will be preserved."

Comment 6 Steve Tyler 2013-08-01 12:02:06 UTC
Created attachment 781547 [details]
screenshot showing SUMMARY OF CHANGES dialog after completing Manual Partitioning

After completing Manual Partitioning, the installer displays an informative SUMMARY OF CHANGES dialog listing all of the changes to the disk(s) that will take effect after installation begins. Could you comment on it?

Although you can't tell from the screenshot, there is a second disk, sdb, which I did not select as a possible install target.

Tested with:
$ qemu-kvm -m 2048 -hda f19-test-2.img -hdb f20-test-1.img -cdrom ~/xfr/fedora/F19/Fedora-19-x86_64-DVD.iso -vga std -boot menu=on

Comment 7 Steve Tyler 2013-08-01 12:08:33 UTC
(In reply to Peter Kotvan from comment #4)
...
> * Automatically configure my Fedora installation to disk(s) I selected and
> return me to the main menu. Existing partitions will be preserved.
                                       ^^^^^^^^^^
There could be logical volumes too ...

Comment 8 Peter Kotvan 2013-08-02 10:53:03 UTC
(In reply to Steve Tyler from comment #6)
...
> Although you can't tell from the screenshot, there is a second disk, sdb,
> which I did not select as a possible install target.

Is there another LVM physical volume on sdb? I am not sure what should be the right behaviour in this case...

Comment 9 Peter Kotvan 2013-08-02 10:57:00 UTC
(In reply to Steve Tyler from comment #7)
...
> There could be logical volumes too ...

What about this: Existing volumes will be preserved. ?

Comment 10 Steve Tyler 2013-08-02 11:08:04 UTC
(In reply to Peter Kotvan from comment #9)
> (In reply to Steve Tyler from comment #7)
> ...
> > There could be logical volumes too ...
> 
> What about this: Existing volumes will be preserved. ?

I believe Adam W. has proposed that terminology, although I would amend it to:
Existing storage volumes will be preserved.
         ^^^^^^^

CCing Adam for comment.


Note You need to log in before you can comment on or make changes to this bug.