Bug 979132 - openshift-origin-broker.spec is doing some very odd things, needs a clean up
Summary: openshift-origin-broker.spec is doing some very odd things, needs a clean up
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: OKD
Classification: Red Hat
Component: Pod
Version: 2.x
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Adam Miller
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-06-27 17:28 UTC by Adam Miller
Modified: 2015-05-15 02:20 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-07-30 17:13:58 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Adam Miller 2013-06-27 17:28:30 UTC 
Description of problem:

Currently in the spec file, all files are copied recursively into the buildroot and then moved around based on conditionals.

    cp -r . %{buildroot}%{brokerdir}

This should not be done, the files should be installed (laid down in the buildroot) once and not moved around so much. This isn't inherently an error but it's bad practice.
Comment 1 Adam Miller 2013-07-30 17:13:58 UTC 
Troy beat me to it, but this has been cleaned up.

https://github.com/openshift/origin-server/pull/3219
Note You need to log in before you can comment on or make changes to this bug.