Red Hat Bugzilla – Bug 979134
oo-accept-node does not properly account for old cart versions
Last modified: 2015-05-14 19:22:34 EDT
Description of problem:
The "check_cartridge_repository" function in oo-accept-node gets confused if there's an older version of the cartridge in the repository as well as a newer one.
Version-Release number of selected component (if applicable):
Always, if there's both an old and new version installed
Steps to Reproduce:
1. Upgrade cartridges
2. run oo-accept-node
FAIL: cart repo version is older than /usr/libexec/openshift/cartridges/v2/phpmyadmin/metadata/manifest.yml
FAIL: cart repo version is older than /usr/libexec/openshift/cartridges/v2/python/metadata/manifest.yml
FAIL: cart repo version is older than /usr/libexec/openshift/cartridges/v2/switchyard/metadata/manifest.yml
FAIL: cart repo version is older than /usr/libexec/openshift/cartridges/v2/zend/metadata/manifest.yml
FAIL: cart repo version is older than /usr/libexec/openshift/cartridges/v2/jbossews/metadata/manifest.yml
FAIL: cart repo version is older than /usr/libexec/openshift/cartridges/v2/perl/metadata/manifest.yml
FAIL: cart repo version is older than /usr/libexec/openshift/cartridges/v2/php/metadata/manifest.yml
FAIL: cart repo version is older than /usr/libexec/openshift/cartridges/v2/jbosseap/metadata/manifest.yml
FAIL: cart repo version is older than /usr/libexec/openshift/cartridges/v2/jbossas/metadata/manifest.yml
Taking off the blocker list. To work around, do the following:
find /var/lib/openshift/.cartridge_repository -name manifest.yml | xargs touch
Back on blocker list.
Master pull request:
Stage pull request:
Commit pushed to master at https://github.com/openshift/origin-server
Bug 979134 - the v1 cart version check was matching older versions of the v2 cart and is no longer necessary.
Checked on devenv-stage_382,
1. Modify the Cartridge Version to older one in manifest file under /usr/libexec/openshift/cartridges/v2/zend
2. Install the cartridge
3. Check there are two versions installed.
# tree /var/lib/openshift/.cartridge_repository/redhat-zend/ -L 1
4. Run oo-accept-node
It will not report the cartridge version unmatched.
Move bug to verified.