Red Hat Bugzilla – Bug 980759
Python-docutils rebuild fails with Python 3.3.2
Last modified: 2016-01-31 21:15:05 EST
Python-docutils fails to build in Fedora 19 due to changes in Python 3.3.2 and the csv module.
I took the liberty of preparing the patches: test-tables-quotes.patch for , docutils-strict-csv-parser.patch for  and finally spec.patch.
Should you deem this worthy of being accepted I wonder if mayhap I could get commit rights and amend this myself? :) Python-docutils is important for our team, I am told, and being able to fix things quickly would be of some benefit.
Created attachment 768125 [details]
fix for sourceforge.net/p/docutils/bugs/235/
Created attachment 768126 [details]
fix for sourceforge.net/p/docutils/bugs/210/
Created attachment 768127 [details]
I'd love to have a comaintainer who can care for python3 issues. However, for your two patches it looks like upstream made some changes when they committed them. We should go with what's in upstream's svn repository instead of what was posted to the bug tracker.
When upstream doesn't have links to the commit that added the patch we should probably have those in addition to the link to the bug tracker in the spec file (part of this is just that sourceforge is a pain to get information out of but the second bug doesn't have a commit attached).
One other note -- For the docutils package, we rebase to snapshots from the current svn tree more often than other packages. This is just because of the nature of how upstream develops, fixes, and makes releases. It may be time for us to make a new snapshot that pulls in all of these changes. If you'd like to prepare a new docutils package based on a snapshot, that would also be a suitable approach for me to review that spec file diff with a view towards giving you commit.
(In reply to Toshio Ernie Kuratomi from comment #4)
> One other note -- For the docutils package, we rebase to snapshots from the
> current svn tree more often than other packages. This is just because of
> the nature of how upstream develops, fixes, and makes releases. It may be
> time for us to make a new snapshot that pulls in all of these changes. If
> you'd like to prepare a new docutils package based on a snapshot, that would
> also be a suitable approach for me to review that spec file diff with a view
> towards giving you commit.
Sounds like a plan! I'll look into it.
Created attachment 773570 [details]
rebase to r7687
I've added the patch, hope it's fine. :)
I noticed you removed one of the comments for disabling a test -- I assume you also removed the part of the patch that was disabling that test?
Also, go ahead and apply for comaintainership and I'll approve you here: https://admin.fedoraproject.org/pkgdb/acls/name/python-setuptools
Oops, sorry -- too many windows open in my browser. This is the correct pkgdb link: https://admin.fedoraproject.org/pkgdb/acls/name/python-docutils
(In reply to Toshio Ernie Kuratomi from comment #8)
> I noticed you removed one of the comments for disabling a test -- I assume
> you also removed the part of the patch that was disabling that test?
Indeed I did!
> Oops, sorry -- too many windows open in my browser. This is the correct pkgdb > link: https://admin.fedoraproject.org/pkgdb/acls/name/python-docutils
Done. I hope, at least, that page always seems to eagerly do just what I don't want it to do.
Cool. You're now a comaintainer. Feel free to push the fix/update and build :-)
python-docutils-0.11-0.1.20130715svn7687.fc19 has been submitted as an update for Fedora 19.
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-docutils-0.11-0.1.20130715svn7687.fc19'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
python-docutils-0.11-0.1.20130715svn7687.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.