Bug 983211 - Set X_FORWARDED_FOR for calls to broker to get IP-address traceability
Summary: Set X_FORWARDED_FOR for calls to broker to get IP-address traceability
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Website
Version: 2.x
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: ---
Assignee: Clayton Coleman
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-10 17:39 UTC by Jordan Liggitt
Modified: 2015-05-15 01:28 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-10-17 13:27:40 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Jordan Liggitt 2013-07-10 17:39:22 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Fabiano Franz 2013-08-08 18:57:06 UTC
Taking out UpcomingRelease, please provide a description.

Comment 2 Fabiano Franz 2013-08-19 20:24:02 UTC
Not enough data, if still an issue please reopen and provide a description.

Comment 3 Jordan Liggitt 2013-08-23 19:53:06 UTC
The IP address a web request to the console comes in on doesn't get forwarded to the broker, so none of the broker logging of IPs is useful for console-initiated requests.

Comment 4 Clayton Coleman 2013-09-13 20:22:11 UTC
Fixed with 461d1e3 in li and 48acef0 in origin-server, will be part of https://github.com/openshift/li/pull/1903

Comment 5 Yujie Zhang 2013-09-24 07:52:43 UTC
hi Clayton,
Can you give me some suggestions about how to veirfy this bug from QE side? Thanks!

Comment 6 Clayton Coleman 2013-09-24 14:08:51 UTC
Perform an action in the console.  Check the broker/user_action.log and verify that the IP address of the logged action matches your local IP address.  The X-Forwarded-For header is sent by the console to the broker so that the broker knows what the console user's IP is.

Comment 8 Yujie Zhang 2013-09-25 10:03:02 UTC
Tested on fork_ami_origin_ui_72_membership_845, the IP in user_action.log equals my external IP now, so verify this bug, thanks.

Comment 9 openshift-github-bot 2013-09-27 00:33:12 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/48acef00cbe83db32a66527e38fe4e3bba62fedb
Bug 983211 - Pass remote_ip to broker

Comment 10 openshift-github-bot 2013-09-27 07:14:41 UTC
Commit pushed to master at https://github.com/openshift/li

https://github.com/openshift/li/commit/89706a64fa836db41534eb711be7ad4e99119087
Origin UI 72 - Membership

-------------
Includes bugs

Bug 983211 - Pass remote_ip to broker


Note You need to log in before you can comment on or make changes to this bug.