Description of problem: ssh into instance and run oo-pam-enable -h / oo-pam-disable -h, "/usr/bin/oo-pam-enable: invalid option -- h" shown. Version-Release number of selected component (if applicable): devenv_3492 rhc-1.11.4 How reproducible: Always Steps to Reproduce: 1. ssh into instance 2. oo-pam-enable -h 3. oo-pam-disable -h Actual results: [root@ip-10-114-37-122 ~]# oo-pam-enable -h /usr/bin/oo-pam-enable: invalid option -- h == Synopsis /usr/bin/oo-pam-enable: Enable pam for a gear This command must be run as root. == Usage To enable pam for a gear with UUID: /usr/bin/oo-pam-enable --with-container-uuid UUID == List of arguments -c|--with-container-uuid gear_uuid Unique identifier for the gears -d|--debug Enable debug mode -h|--help Print this message [root@ip-10-114-37-122 ~]# oo-pam-disable -h /usr/bin/oo-pam-disable: invalid option -- h == Synopsis /usr/bin/oo-pam-disable: Disable pam for a gear This command must be run as root. == Usage To disable pam for a gear with UUID: /usr/bin/oo-pam-disable --with-container-uuid UUID == List of arguments -c|--with-container-uuid gear_uuid Unique identifier for the gears -d|--debug Enable debug mode -h|--help Print this message Expected results: should not show: /usr/bin/oo-pam-enable: invalid option -- h /usr/bin/oo-pam-disable: invalid option -- h
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/45708b7114c6ffdb28acf0fde19df913fa59c597 Bug 983923 - Add "-h" as an argument to get help.
test on devenv_3539 test ok with oo-pam-enable -h, but "/usr/bin/oo-pam-disable: invalid option -- h" still show with oo-pam-disable -h [root@ip-10-145-149-41 ~]# oo-pam-enable -h == Synopsis /usr/bin/oo-pam-enable: Enable pam for a gear This command must be run as root. == Usage To enable pam for a gear with UUID: /usr/bin/oo-pam-enable --with-container-uuid UUID To enable pam for all gears: /usr/bin/oo-pam-enable --with-all-containers == List of arguments -c|--with-container-uuid gear_uuid Unique identifier for the gears -a|--with-all-containers Run on all gears -d|--debug Enable debug mode -h|--help Print this message [root@ip-10-145-149-41 ~]# oo-pam-disable -h /usr/bin/oo-pam-disable: invalid option -- h == Synopsis /usr/bin/oo-pam-disable: Disable pam for a gear This command must be run as root. == Usage To disable pam for a gear with UUID: /usr/bin/oo-pam-disable --with-container-uuid UUID To disable pam for all gears: /usr/bin/oo-pam-disable --with-all-containers == List of arguments -c|--with-container-uuid gear_uuid Unique identifier for the gears -a|--with-all-containers Run on all gears -d|--debug Enable debug mode -h|--help Print this message
Good catch, fixed in master.
verified on devenv_3580, both oo-pam-disable -h and oo-pam-enable -h works normally. [root@ip-10-164-36-98 ~]# oo-pam-disable -h == Synopsis /usr/bin/oo-pam-disable: Disable pam for a gear This command must be run as root. == Usage To disable pam for a gear with UUID: /usr/bin/oo-pam-disable --with-container-uuid UUID To disable pam for all gears: /usr/bin/oo-pam-disable --with-all-containers == List of arguments -c|--with-container-uuid gear_uuid Unique identifier for the gears -a|--with-all-containers Run on all gears -d|--debug Enable debug mode -h|--help Print this message [root@ip-10-164-36-98 ~]# oo-pam-enable -h == Synopsis /usr/bin/oo-pam-enable: Enable pam for a gear This command must be run as root. == Usage To enable pam for a gear with UUID: /usr/bin/oo-pam-enable --with-container-uuid UUID To enable pam for all gears: /usr/bin/oo-pam-enable --with-all-containers == List of arguments -c|--with-container-uuid gear_uuid Unique identifier for the gears -a|--with-all-containers Run on all gears -d|--debug Enable debug mode -h|--help Print this message