Spec URL: http://lbzip2.org/lbzip2-utils.spec SRPM URL: http://lbzip2.org/lbzip2-utils-1.0-1.fc20.src.rpm Description: This package provides a collection of utility programs to work with compressed files in bz2 format. These utilities are supplementary to lbzip2 compression tool. Fedora Account System Username: mizdebsk
I'll take this.
Let's first look into the spec itself. Issue: 1. Please drop BuildRoot tag as modern RPM has already supported it. 2. Please drop rm -rf %{buildroot} in the %install section, same reason as above. 3. Please remove whole %clean section, same reason as #1. 4. Please remove %defattr(-,root,root,-), same reason...
I'm sorry, I forgot to state that in the initial request, but I am going to submit this package for EPEL 5. All of the things mentioned in comment #2 are needed there. If you insist I can remove them and for EPEL 5 use a different spec file, but I would rather keep the same spec across all branches.
OK. I'll fill a bug when EL5 is terminated... I've checked everything, fedora-review and manual, no problems. APPROVED.
Thank you. New Package SCM Request ======================= Package Name: lbzip2-utils Short Description: Utilities for working with bzip2 compressed files Owners: mizdebsk Branches: f19 el5 el6
Git done (by process-git-requests).
> but I am going to submit this package for EPEL 5. > All of the things mentioned in comment #2 are needed there. RPM in EL5 is new enough, so you can drop %defattr.
(In reply to Michael Schwendt from comment #7) > > but I am going to submit this package for EPEL 5. > > All of the things mentioned in comment #2 are needed there. > > RPM in EL5 is new enough, so you can drop %defattr. I didn't not know that. I'll keep that in mind, Thank you.