RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 985187 - fipvlan should print the proper message and return the correct code if the fcoe and libfcoe modules are not loaded
Summary: fipvlan should print the proper message and return the correct code if the fc...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: fcoe-utils
Version: 7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Chris Leech
QA Contact: guazhang@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-17 04:28 UTC by Xiaowei Li
Modified: 2023-03-08 07:26 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-12-15 07:27:00 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Xiaowei Li 2013-07-17 04:28:16 UTC 
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. modprobe -r fcoe 
2. modprobe -r libfcoe
3. fipvlan -c -a -s

issues:
1. fipvlan return 0 but actually it does not create and start the fcoe instance successfully 
2. fipvlan should load libfcoe and fcoe modules automatically.
3. /sys/module/libfcoe/parameters/create is deprecated in RHEL 7.0. The default
is to use the newer /sys/bus/fcoe/ interfaces if they are available. so please print the proper error messages.

Actual results:
[root@storageqe-13 ~]# fipvlan -a -c -s
Fibre Channel Forwarders Discovered
interface       | VLAN | FCF MAC          
------------------------------------------
p2p1            | 802  | 00:05:73:b2:7f:00
p2p2            | 802  | 00:05:73:b2:7f:00


Starting FCoE on interface p2p1.802-fcoe
fipvlan: fcoe_mod_instance_start: error 2 No such file or directory
fipvlan: fcoe_mod_instance_start: Failed to open file: /sys/module/libfcoe/parameters/create
fipvlan: fcoe_mod_instance_start: error 2 No such file or directory
fipvlan: fcoe_mod_instance_start: May be fcoe stack not loaded, starting fcoe service will fix that
Starting FCoE on interface p2p2.802-fcoe
fipvlan: fcoe_mod_instance_start: error 2 No such file or directory
fipvlan: fcoe_mod_instance_start: Failed to open file: /sys/module/libfcoe/parameters/create
fipvlan: fcoe_mod_instance_start: error 2 No such file or directory
fipvlan: fcoe_mod_instance_start: May be fcoe stack not loaded, starting fcoe service will fix that
[root@storageqe-13 ~]# echo $?
0

[root@storageqe-13 ~]# fcoeadm -i
No FCoE interfaces created.


Expected results:


Additional info:
Comment 1 Xiaowei Li 2013-07-17 04:29:05 UTC 
fcoe-utils-1.0.28-2.el7.x86_64
Comment 3 Xiaowei Li 2013-08-19 13:36:30 UTC 
please set the dev_ack. thanks a lot.
Comment 4 Petr Šabata 2013-08-19 15:29:26 UTC 
No, please do not.

I'm not sure whether this (as it's not hardware related) can be autoloaded or not.  The tool definitely shouldn't handle more than a possible functionality request.

What benefit this actually brings?  And as far as I know, we don't autoload such modules in other tools either (e.g. iproute).
Comment 5 Xiaowei Li 2013-08-20 02:43:13 UTC 
(In reply to Petr Šabata from comment #4)
> No, please do not.
> 
> I'm not sure whether this (as it's not hardware related) can be autoloaded
> or not.  The tool definitely shouldn't handle more than a possible
> functionality request.
> 
> What benefit this actually brings?  And as far as I know, we don't autoload
> such modules in other tools either (e.g. iproute).

I think there are two issues here:

It's okay by me if fipvlan does not load the related modules automatically but it should print the proper message and return the correct code.

correct the bug title and the three issues.

1. fipvlan return 0 but actually it does not create and start the fcoe instance successfully. it should return the correct code.
2. fipvlan should just tell the users the libfcoe and fcoe modules are not loaded then exit. please don't print such message since /sys/module/libfcoe/parameters/create is deprecated in RHEL 7.0.
Comment 6 Petr Šabata 2013-11-19 09:36:55 UTC 
The nature of this fix is more like an RFE.  Moving to 7.1.
Comment 13 RHEL Program Management 2020-12-15 07:27:00 UTC 
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.
Note You need to log in before you can comment on or make changes to this bug.