Red Hat Bugzilla – Bug 985915
Review Request: perl-BSSolv - A new approach to package dependency solving
Last modified: 2013-07-23 03:52:48 EDT
Spec URL: http://miroslav.suchy.cz/fedora/perl-BSSolv/perl-BSSolv.spec
SRPM URL: http://miroslav.suchy.cz/fedora/perl-BSSolv/perl-BSSolv-0.18.2-2.git228d412.fc19.src.rpm
Using a Satisfyability Solver to compute package dependencies.
Fedora Account System Username: msuchy
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5627553
So this package basically bundles libsolv?
Where do the perl files come from?
You shouldn't BR perl-devel or gcc-c++.
> So this package basically bundles libsolv?
Yes, unless bug 985905 is resolved.
> Where do the perl files come from?
I will add comment into spec about that.
Unfortunatelly there is no ultimate source just for standalone package. And BSSolv is BR for obs-server, where it is included in upstream, so we will have problem with bootstraping.
>You shouldn't BR perl-devel or gcc-c++.
I just come to agreement with akozumpl that bug 985905 will be resolved soon. When it will be done, I will submit new src.rpm, which will be linked against satsolv from distribution.
I looked at the sources and, ehm, they're not good. E.g. BSSolv.pm does not contain any documentation. I looked at BSHTTP.pm and I was amazed–this is reimplementation of HTTP decoder including naïve chunk-decoder. Couldn't they use Net::HTTP? I worry about number of bugs hidden there.
BSHTTP.pm is different issue and very different package.
This BZ is just about BSSolv.pm and BSSolv.xs.
Note: this works only in rawhide.
I raised few question on upstream and it seems that they will make perl-BSSolv subpackage of obs-server. So I'm closing this review for now.