Bug 985915 - Review Request: perl-BSSolv - A new approach to package dependency solving
Summary: Review Request: perl-BSSolv - A new approach to package dependency solving
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 985905
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-18 13:46 UTC by Miroslav Suchý
Modified: 2013-07-23 07:52 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-07-23 07:52:48 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Miroslav Suchý 2013-07-18 13:46:15 UTC
Spec URL: http://miroslav.suchy.cz/fedora/perl-BSSolv/perl-BSSolv.spec
SRPM URL: http://miroslav.suchy.cz/fedora/perl-BSSolv/perl-BSSolv-0.18.2-2.git228d412.fc19.src.rpm
Description: 
Using a Satisfyability Solver to compute package dependencies.

Fedora Account System Username: msuchy
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5627553

Comment 1 Petr Šabata 2013-07-18 14:13:44 UTC
So this package basically bundles libsolv?
Where do the perl files come from?
You shouldn't BR perl-devel or gcc-c++.

Comment 2 Miroslav Suchý 2013-07-18 14:45:06 UTC
> So this package basically bundles libsolv?
Yes, unless bug 985905 is resolved.

> Where do the perl files come from?
from:
https://github.com/openSUSE/open-build-service/tree/master/src/backend
I will add comment into spec about that.
Unfortunatelly there is no ultimate source just for standalone package. And BSSolv is BR for obs-server, where it is included in upstream, so we will have problem with bootstraping.

>You shouldn't BR perl-devel or gcc-c++.
ok

Comment 3 Miroslav Suchý 2013-07-19 08:36:40 UTC
I just come to agreement with akozumpl that bug 985905 will be resolved soon. When it will be done, I will submit new src.rpm, which will be linked against satsolv from distribution.

Comment 4 Petr Pisar 2013-07-22 15:08:09 UTC
I looked at the sources and, ehm, they're not good. E.g. BSSolv.pm does not contain any documentation. I looked at BSHTTP.pm and I was amazed–this is reimplementation of HTTP decoder including naïve chunk-decoder. Couldn't they use Net::HTTP? I worry about number of bugs hidden there.

Comment 5 Miroslav Suchý 2013-07-22 17:11:17 UTC
BSHTTP.pm is different issue and very different package.
This BZ is just about BSSolv.pm and BSSolv.xs.

Comment 7 Miroslav Suchý 2013-07-23 07:52:48 UTC
I raised few question on upstream and it seems that they will make perl-BSSolv subpackage of obs-server. So I'm closing this review for now.


Note You need to log in before you can comment on or make changes to this bug.