Bug 986340 - Review Request: perl-Socket-MsgHdr - Sendmsg, recvmsg and ancillary data operations
Summary: Review Request: perl-Socket-MsgHdr - Sendmsg, recvmsg and ancillary data oper...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-19 13:08 UTC by Miroslav Suchý
Modified: 2013-08-02 03:45 UTC (History)
3 users (show)

Fixed In Version: perl-Socket-MsgHdr-0.04-3.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-02 03:29:24 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Miroslav Suchý 2013-07-19 13:08:59 UTC
Spec URL: http://miroslav.suchy.cz/fedora/perl-Socket-MsgHdr/perl-Socket-MsgHdr.spec
SRPM URL: http://miroslav.suchy.cz/fedora/perl-Socket-MsgHdr/perl-Socket-MsgHdr-0.04-2.fc19.src.rpm
Description:
Socket::MsgHdr provides advanced socket messaging operations via sendmsg
and recvmsg. Like their C counterparts, these functions accept few
parameters, instead stuffing a lot of information into a complex structure.

Fedora Account System Username: msuchy

Comment 1 Petr Šabata 2013-07-19 13:25:30 UTC
The package fails to build in mock.

You're missing some build-time dependencies, namely:
 - perl (called in spec)
 - perl(bytes), ./20send.t:10, ./30recv.t:10 (recommended)
 - perl(Exporter), lib/Socket/MsgHdr.pm:69
 - perl(Socket), ./10basic.t:11, ./20send.t:13, ./30recv.t:13
 - perl(strict), all over the place (recommended)
 - perl(Test::More), ./10basic.t:8, ./20send.t:8, ./30recv.t:8
 - perl(XSLoader), lib/Socket/MsgHdr.pm:62

Tips:
 - You may use DESTDIR instead of PERL_INSTALL_ROOT
 - Line 32 is unnecessary
 - You could use simple 'perl' instead of the '%{__perl}' macro

Comment 3 Petr Šabata 2013-07-20 17:47:30 UTC
Ok, looks good.  Approving.

Comment 4 Miroslav Suchý 2013-07-22 07:24:34 UTC
New Package SCM Request
=======================
Package Name: perl-Socket-MsgHdr
Short Description: Sendmsg, recvmsg and ancillary data operations
Owners: msuchy
Branches: f19 f18 el6
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2013-07-22 10:08:43 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2013-07-22 11:26:02 UTC
perl-Socket-MsgHdr-0.04-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Socket-MsgHdr-0.04-3.fc19

Comment 7 Fedora Update System 2013-07-22 11:27:05 UTC
perl-Socket-MsgHdr-0.04-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/perl-Socket-MsgHdr-0.04-3.fc18

Comment 8 Fedora Update System 2013-07-23 01:03:19 UTC
perl-Socket-MsgHdr-0.04-3.fc18 has been pushed to the Fedora 18 testing repository.

Comment 9 Fedora Update System 2013-08-02 03:29:24 UTC
perl-Socket-MsgHdr-0.04-3.fc18 has been pushed to the Fedora 18 stable repository.

Comment 10 Fedora Update System 2013-08-02 03:45:45 UTC
perl-Socket-MsgHdr-0.04-3.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.