Red Hat Bugzilla – Bug 987457
Review Request: rubygem-fast_xs - Provides C extensions for escaping text
Last modified: 2016-01-04 00:51:22 EST
Spec URL: http://miroslav.suchy.cz/fedora/rubygem-fast_xs/rubygem-fast_xs.spec
SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-fast_xs/rubygem-fast_xs-0.8.0-2.fc19.src.rpm
fast_xs provides C extensions for escaping text.
The original String#fast_xs method is based on the xchar code by Sam Ruby:
_why also packages an older version with Hpricot (patches submitted).
The version here should be compatible with the latest version of Hpricot
Ruby on Rails will automatically use String#fast_xs from either Hpricot
or this gem version with the bundled Builder package.
String#fast_xs is an almost exact translation of Sam Ruby's original
implementation (String#to_xs), but it does escape """ (which is an
optional, but all parsers are able ot handle it. XML::Builder as
packaged in Rails 2.0 will be automatically use String#fast_xs instead
of String#to_xs available.
Fedora Account System Username: msuchy
I will take it for a review.
* Escape macros in comments
rubygem-fast_xs.spec:57: W: macro-in-comment %gem_dir
* Description of -doc package should end up with a dot and the description of the main package could a little more formatted (2 line breaks after a paragraph).
Otherwise the spec looks good, it builds, installs & works. Since the issues are minor and could be fixed before pushing I am APPROVING this package.
New Package SCM Request
Package Name: rubygem-fast_xs
Short Description: Provides C extensions for escaping text
Git done (by process-git-requests).
rubygem-fast_xs-0.8.0-3.fc19 has been submitted as an update for Fedora 19.
rubygem-fast_xs-0.8.0-3.fc19 has been pushed to the Fedora 19 testing repository.
rubygem-fast_xs-0.8.0-3.fc19 has been pushed to the Fedora 19 stable repository.