Spec URL: http://miroslav.suchy.cz/fedora/rubygem-mobileesp_converted/rubygem-mobileesp_converted.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-mobileesp_converted/rubygem-mobileesp_converted-0.2.1-4.fc19.src.rpm Description: Autoconverted version (from Java to Ruby) of MobileESP library. Fedora Account System Username: msuchy Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=5654830
Taking.
Please fix: * Remove this commented line as it has no value nor purpose and it's confusing. #cp %{gem_name}.gemspec %{buildroot}/%{gem_spec} * Remove shebang from non-executable Rakefile #!/usr/bin/env rake * Remove BR on bundler. We try to avoid running test suites using bundler in Fedora. You should be able to run it without it by deleting its require from tests source code. BuildRequires: rubygem(bundler) * Please ask upstream to include and include license in a separate license file, especially, because this gem is a derivative work. Please consider: * Consider keeping original .gemspec in %doc for clarification since you are generating your own. %exclude %{gem_instdir}/%{gem_name}.gemspec Thanks.
>Please ask upstream to include and include license in a separate license file, especially, because this gem is a derivative work. https://github.com/jistr/mobileesp_converted/issues/2 All other items are updated: Spec URL: http://miroslav.suchy.cz/fedora/rubygem-mobileesp_converted/rubygem-mobileesp_converted.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-mobileesp_converted/rubygem-mobileesp_converted-0.2.1-5.fc19.src.rpm
Thanks, it's looks good now. I would personally move removal of bundler dep to %check, where it makes clearer why are you doing so. Please consider before pushing. APPROVED.
New Package SCM Request ======================= Package Name: mobileesp_converted Short Description: Provides device type detection based on HTTP request headers Owners: msuchy Branches: f19 InitialCC:
Requested package name mobileesp_converted doesn't match bug summary rubygem-mobileesp_converted, please correct.
New Package SCM Request ======================= Package Name: rubygem-mobileesp_converted Short Description: Provides device type detection based on HTTP request headers Owners: msuchy Branches: f19 InitialCC:
Git done (by process-git-requests).
rubygem-mobileesp_converted-0.2.1-6.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-mobileesp_converted-0.2.1-6.fc19
rubygem-mobileesp_converted-0.2.1-6.fc19 has been pushed to the Fedora 19 testing repository.
rubygem-mobileesp_converted-0.2.1-6.fc19 has been pushed to the Fedora 19 stable repository.