Bug 988462 - add_maven_depmap macro should respect additional (-a) depmaps
Summary: add_maven_depmap macro should respect additional (-a) depmaps
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: javapackages-tools
Version: rawhide
Hardware: All
OS: Linux
high
high
Target Milestone: ---
Assignee: Mikolaj Izdebski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 988797
TreeView+ depends on / blocked
 
Reported: 2013-07-25 16:05 UTC by Roland Grunberg
Modified: 2013-07-26 12:04 UTC (History)
5 users (show)

Fixed In Version: 2.0.1-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-07-26 07:41:48 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Patch (1.10 KB, patch)
2013-07-25 16:06 UTC, Roland Grunberg 		no flags Details | Diff
View All

Description Roland Grunberg 2013-07-25 16:05:57 UTC 
Running the add_maven_depmap script with N additional mappings specified (using -a) results in the mapping from the pom file being repeated N+1 times in the fragment file. The gid/aid/version of the additional mappings are never set in the loop that prints out the content of the Fragment class. I guess one way around this could be to just set the contents of the fragment each time to a different gid/aid/version.

I've attached a patch that seems to get things working. Feel free to change as needed.
Comment 1 Roland Grunberg 2013-07-25 16:06:58 UTC 
Created attachment 778351 [details]
Patch
Comment 2 Mikolaj Izdebski 2013-07-26 07:21:32 UTC 
Thank you for the report and patch.
It appears to fix a known bug, I'll look into it.
Comment 3 Mikolaj Izdebski 2013-07-26 07:31:43 UTC 
Fixed upstream in 2.0.1:
https://github.com/mizdebsk/javapackages/commit/e5095ae
Comment 4 Mikolaj Izdebski 2013-07-26 07:34:21 UTC 
Fixed in javapackages-tools-2.0.1-1
Comment 5 Mikolaj Izdebski 2013-07-26 07:41:48 UTC 
I believe that this bug is fixed in javapackages-tools-2.0.1-1,
which is available in Fedora Rawhide, so I am closing this bug now.

The build containing the fix can be found at Koji:
http://koji.fedoraproject.org/koji/buildinfo?buildID=438103
Note You need to log in before you can comment on or make changes to this bug.