Bug 988462 - add_maven_depmap macro should respect additional (-a) depmaps
add_maven_depmap macro should respect additional (-a) depmaps
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: javapackages-tools (Show other bugs)
rawhide
All Linux
high Severity high
: ---
: ---
Assigned To: Mikolaj Izdebski
Fedora Extras Quality Assurance
: Upstream
Depends On:
Blocks: 988797
  Show dependency treegraph
 
Reported: 2013-07-25 12:05 EDT by Roland Grunberg
Modified: 2013-07-26 08:04 EDT (History)
5 users (show)

See Also:
Fixed In Version: 2.0.1-1
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-07-26 03:41:48 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Patch (1.10 KB, patch)
2013-07-25 12:06 EDT, Roland Grunberg
no flags Details | Diff

  None (edit)
Description Roland Grunberg 2013-07-25 12:05:57 EDT
Running the add_maven_depmap script with N additional mappings specified (using -a) results in the mapping from the pom file being repeated N+1 times in the fragment file. The gid/aid/version of the additional mappings are never set in the loop that prints out the content of the Fragment class. I guess one way around this could be to just set the contents of the fragment each time to a different gid/aid/version.

I've attached a patch that seems to get things working. Feel free to change as needed.
Comment 1 Roland Grunberg 2013-07-25 12:06:58 EDT
Created attachment 778351 [details]
Patch
Comment 2 Mikolaj Izdebski 2013-07-26 03:21:32 EDT
Thank you for the report and patch.
It appears to fix a known bug, I'll look into it.
Comment 3 Mikolaj Izdebski 2013-07-26 03:31:43 EDT
Fixed upstream in 2.0.1:
https://github.com/mizdebsk/javapackages/commit/e5095ae
Comment 4 Mikolaj Izdebski 2013-07-26 03:34:21 EDT
Fixed in javapackages-tools-2.0.1-1
Comment 5 Mikolaj Izdebski 2013-07-26 03:41:48 EDT
I believe that this bug is fixed in javapackages-tools-2.0.1-1,
which is available in Fedora Rawhide, so I am closing this bug now.

The build containing the fix can be found at Koji:
http://koji.fedoraproject.org/koji/buildinfo?buildID=438103

Note You need to log in before you can comment on or make changes to this bug.