Spec URL: http://miroslav.suchy.cz/fedora/rubygem-xmlhash/rubygem-xmlhash.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-xmlhash/rubygem-xmlhash-1.3.5-4.fc19.src.rpm Description: A small C module that wraps libxml2's xmlreader to parse a XML string into a ruby hash. Fedora Account System Username: msuchy Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5660052
Taking.
* Use %%gem_dir to escape macro in comment rubygem-xmlhash.spec:50: W: macro-in-comment %gem_dir * Adjust summary rubygem-xmlhash.src: E: summary-too-long C A small C module that wraps libxml2's xmlreader to parse a XML string into a ruby hash * Move %doc %{gem_instdir}/README.txt to the main package since it contains licensing information, ideally you could ask upstream to provide a separate license file. * I believe that /ext files used to build the extension could be probably put into -doc subpackage for clarification. * Run the test suite with: testrb -Ilib test/test_xmlhash.rb so the library is properly loaded and tests run. Other than that I have no complains. It builds, installs and works in mock. Please fix the issues above.
> * I believe that /ext files used to build the extension could be probably put into -doc subpackage for clarification. I would rather keep it just in .src.rpm Other items updated: Spec URL: http://miroslav.suchy.cz/fedora/rubygem-xmlhash/rubygem-xmlhash.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-xmlhash/rubygem-xmlhash-1.3.5-5.fc19.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5778895 APPROVING.
New Package SCM Request ======================= Package Name: rubygem-xmlhash Short Description: A small C module to parse a XML string into a ruby hash Owners: msuchy Branches: f19 InitialCC:
Git done (by process-git-requests).
rubygem-xmlhash-1.3.5-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-xmlhash-1.3.5-5.fc19
rubygem-xmlhash-1.3.5-5.fc19 has been pushed to the Fedora 19 testing repository.
rubygem-xmlhash-1.3.5-5.fc19 has been pushed to the Fedora 19 stable repository.