Bug 989541 - Dist-geo-rep : 'gluster volume geo <master_vol> <slave_ip>::<slave_vol> stop' gives wrong error message if session does not exist
Summary: Dist-geo-rep : 'gluster volume geo <master_vol> <slave_ip>::<slave_vol> stop'...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Avra Sengupta
QA Contact:
URL:
Whiteboard:
Depends On: 989248
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-29 13:39 UTC by Avra Sengupta
Modified: 2014-07-11 19:17 UTC (History)
5 users (show)

Fixed In Version: glusterfs-3.5.1
Doc Type: Bug Fix
Doc Text:
Clone Of: 989248
Environment:
Last Closed: 2014-07-11 19:17:39 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Comment 1 Anand Avati 2013-07-29 13:42:31 UTC 
REVIEW: http://review.gluster.org/5417 (glusterd : Checking session created or not in case of geo-rep stop) posted (#1) for review on master by Avra Sengupta (asengupt)
Comment 2 Avra Sengupta 2013-07-29 13:43:21 UTC 
Performing statefile check in case of geo-rep stop, so as to provide proper error message in case session is not created.

However in case of geo-rep stop force, we allow the command to succeed even in case that the session is not created, because the stop command is a failsafe command to stop running geo-rep sessions on any nodes.
Comment 3 Anand Avati 2013-07-31 07:38:41 UTC 
REVIEW: http://review.gluster.org/5417 (glusterd : Checking session created or not in case of geo-rep stop) posted (#2) for review on master by Avra Sengupta (asengupt)
Comment 4 Anand Avati 2013-07-31 16:18:41 UTC 
COMMIT: http://review.gluster.org/5417 committed in master by Vijay Bellur (vbellur) 
------
commit d90b46a23a523720f4e40de993ca61ff0ba43617
Author: Avra Sengupta <asengupt>
Date:   Mon Jul 29 19:05:50 2013 +0530

    glusterd : Checking session created or not in case of geo-rep stop
    
    Performing statefile check in case of geo-rep stop, so as to provide
    proper error message in case session is not created.
    
    However in case of geo-rep stop force, we allow the command to succeed
    even in case that the session is not created, because the stop command
    is a failsafe command to stop running geo-rep sessions on any nodes.
    
    Change-Id: I2b6a0253de977633606c422cbbc9e37cede9a268
    BUG: 989541
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/5417
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Amar Tumballi <amarts>
    Reviewed-by: Vijay Bellur <vbellur>
Note You need to log in before you can comment on or make changes to this bug.