Bug 989627 - nodes lib function decompress() strips more than .gz when filename ends in (g|z)
Summary: nodes lib function decompress() strips more than .gz when filename ends in (g|z)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Pulp
Classification: Retired
Component: nodes
Version: 2.2 Beta
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 2.2.0
Assignee: Jeff Ortel
QA Contact: Preethi Thomas
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-29 16:47 UTC by Jeff Ortel
Modified: 2013-09-10 15:45 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-10 15:45:24 UTC
Embargoed:

Attachments (Terms of Use)

Description Jeff Ortel 2013-07-29 16:47:42 UTC 
The nodes lib function decompress() strips more than .gz when filename ends in (g|z).  Uses rstrip('.gz') which strips the specified characters in any order.  This mainly affects the unit tests which fail when generated file names (see: tempfile) end in (g|z) but could cause other issues.

Example: /tmp/tmpABCD/tmp123z 

when compressed is:

 /tmp/tmpABCD/tmp123z.gz 

but decompresses to:

 /tmp/tmpABCD/tmp123.  

Note trailing 'z' removed.
Comment 1 Jeff Ortel 2013-07-29 16:55:11 UTC 
https://github.com/pulp/pulp/pull/546
Comment 2 Jeff Ortel 2013-08-02 03:42:19 UTC 
build: 2.2.0-0.23.beta
Comment 3 Preethi Thomas 2013-08-09 15:20:41 UTC 
moving to verified

<jortel> as for 989627 - 2 things:
<jortel> 1. we dont see this in production because the file names dont end in (g|z).  really just affected generated tempdir names in unit tests
<jortel> 2. in 2.3 this entire module goes away.
Comment 4 Preethi Thomas 2013-09-10 15:45:24 UTC 
2.2 released
http://repos.fedorapeople.org/repos/pulp/pulp/stable/2.2/
Note You need to log in before you can comment on or make changes to this bug.