Bug 991335 - Bonding options don't take effect after editing its ifcfg configuration file.
Bonding options don't take effect after editing its ifcfg configuration file.
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: initscripts (Show other bugs)
19
Unspecified Linux
unspecified Severity medium
: ---
: ---
Assigned To: Bill Nottingham
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-02 03:39 EDT by Mark Wu
Modified: 2014-03-16 23:34 EDT (History)
11 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-08-05 09:35:55 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Mark Wu 2013-08-02 03:39:57 EDT
Description of problem:
Bonding options don't take effect after editing its ifcfg configuration file.

Version-Release number of selected component (if applicable):
initscripts-9.47-1.fc19.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Create a bonding device. 
2. Make any changes on the BONDING_OPTS in its ifcfg file
3. run ifdown and then ifup agaist it.

Actual results:
The change of BONDING_OPTS doesn't take effect


Expected results:
The actual bonding options should be updated 

Additional info:

Proposed fix:

diff --git a/sysconfig/network-scripts/network-functions b/sysconfig/network-scripts/network-functions
index 1cb26d1..c699fc0 100644
--- a/sysconfig/network-scripts/network-functions
+++ b/sysconfig/network-scripts/network-functions
@@ -428,7 +428,6 @@ is_wireless_device ()
 
 install_bonding_driver ()
 {
-   [ -d "/sys/class/net/$1" ] && return 0
    [ ! -f /sys/class/net/bonding_masters ] && ( modprobe bonding || return 1 )
    if ! grep -sq "$1" /sys/class/net/bonding_masters; then
        echo "+$1" > /sys/class/net/bonding_masters 2>/dev/null
Comment 1 Dan Kenigsberg 2013-08-03 15:13:19 EDT
Note that the very same issue has been fixed for the el6 branch as of Bug 874030.
Comment 2 Lukáš Nykrýn 2013-08-05 09:35:55 EDT
Yep, that is the same issue. Fix in upstream git. Will be included in next release.

Note You need to log in before you can comment on or make changes to this bug.